refactor change-to-swap and submarine-payment parts from GUI to backend #10694
Open
accumulator wants to merge 4 commits into
Open
refactor change-to-swap and submarine-payment parts from GUI to backend #10694accumulator wants to merge 4 commits into
accumulator wants to merge 4 commits into
Conversation
accumulator
force-pushed
the
swap_gui_to_backend_refactor
branch
from
d8aced5 to
b75385e
Compare
…as SubmarineSwapMixin
This covers the functionality for swap use during payments (so, change-to-ln and
submarine-payments) present in gui/qt/confirm_tx_dialog, not the 'standalone' swap.
This is in preparation for adding the same functionality to qml.
- move swap support code from TxEditor to SubmarineSwapMixin
- don't require wallet instance at construction, allow late setting of wallet
swaps: add initialize/destroy methods to SwapServerTransport, to simplify consumer side, adds
a done callback so the transport can be used once ready or failure can be handled.
accumulator
force-pushed
the
swap_gui_to_backend_refactor
branch
from
b75385e to
7c72834
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move submarine swap support code from qt gui to backend and common_qt, where applicable.
This covers the functionality for swap use during payments (so, change-to-ln and
submarine-payments) present in
gui/qt/confirm_tx_dialog, not the 'standalone' swap.This is in preparation for adding the same functionality to qml.
TxEditortoSubmarineSwapMixin