Refactor on_channel_open to accept incoming channels if the source is a trusted zeroconf node #9588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What do you mean by hardcoded? Atm it is the |
SomberNight
reviewed
Feb 28, 2025
After discussing about this with @ecdsa we came to the conclusion that it should be ok to accept non recoverable zeroconf as long as it is not exposed to the GUI. When we ship it in gui we probably need to hardcode them / don't allow for change in the gui due to the trust relation in zeroconf channels. |
SomberNight
reviewed
Mar 4, 2025
ecdsa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the client to accept an incoming channel even if recoverable channels are enabled if the originator is a trusted zeroconf node. This way the client doesn't have to completely disable recoverable channels to get incoming JIT channels and as the trusted nodes are supposed to be hardcoded the client is able to recover them.
If we want to move away from hardcoding the providers we could look into opening recoverable jit channels.
Required for #9584