cli: add hold invoice cli functionality #9685
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f321x
force-pushed
the
hold_invoice_cli
branch
3 times, most recently
from
4a97a3b to
a57b542
Compare
ecdsa
reviewed
May 7, 2025
| memo = "", | ||
| expiry = 3600, | ||
| min_final_cltv_expiry_delta = MIN_FINAL_CLTV_DELTA_FOR_INVOICE * 2, | ||
| callback_url = None, |
There was a problem hiding this comment.
Do we really need to support callback_url?
I thought the idea was to let the user poll using check_hold_invoice.
if we drop this option, I believe we do not need to add a new persisted dict for cli_hold_invoice_callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds four new commands to the CLI which allow handling hold invoices
add_hold_invoicealso allows for registration of an external http endpoint as callback.Users have to bring their own preimage.