gui: Add option to show warnings on wallet close, add warning for swaps #9715
Conversation
|
On Android this is not really a good option. There's no guarantee the app goes through a confirm-close sequence, as the app can be destroyed at any time by the OS. The current confirm-close is there, and it will save the wallet file, but one can easily close the app through other means. Ideally the app should run an android background service to monitor chain and lightning events, so the UI can pop in and out of existence, but that would require a big overhaul.. |
f321x
force-pushed
the
warning_on_close
branch
3 times, most recently
from
ab8fa9e to
0c8a786
Compare
f321x
force-pushed
the
warning_on_close
branch
2 times, most recently
from
f441e7a to
4f5fca3
Compare
|
it would be nice if we could avoid adding a new persisted dict. |
f321x
force-pushed
the
warning_on_close
branch
2 times, most recently
from
907f230 to
d931825
Compare
|
I changed it to a more elegant solution which registers a callback that on wallet close will check if there are swaps with unconfirmed funding transaction. This way there is clear separation between swap and gui code and no persisted dict is required. |
| @@ -1279,6 +1279,15 @@ def get_group_id_for_payment_hash(self, payment_hash): | |||
| if swap: | |||
| return swap.spending_txid if swap.is_reverse else swap.funding_txid | |||
|
|
|||
| def has_pending_swaps(self) -> bool: | |||
There was a problem hiding this comment.
it would be better to return a list of pending swaps, then the GUI can adapt its message depending on the direction of the swap(s)
Allows to register a potential warning shown when the user tries to close the wallet GUI.
A
callback: Callable[[], Optional[str]]can be registered usingAbstract_Wallet.register_closing_warning_callback(callback).On QT wallet close the callbacks will get called, if the callback returns a
strit is presented to the user like this (str is the bottom message):TODO: implement for QML if this gets merged