Txbatcher without password in memory #9751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ecdsa merged 2 commits into master from txbatcher_without_password_in_memory

May 6, 2025

Member

ecdsa commented Apr 19, 2025 •

edited

Loading

This makes it possible to use txbatcher without unlocking the wallet.

if a password is required, send a signal to the GUI, unless the wallet is unlocked.
if a transaction is verified, cancel the password future; the next iteration might not require a password anymore (for example, after a commitment tx has been mined we do not need to sweep anchor outputs anymore)

ecdsa mentioned this pull request

lightning: enable anchor channels by default #9722

Merged

ecdsa force-pushed the txbatcher_without_password_in_memory branch 2 times, most recently from 6d8a9e4 to 9585183 Compare

April 22, 2025 12:26

ecdsa added this to the 4.6.0 milestone

ecdsa force-pushed the txbatcher_without_password_in_memory branch from 9585183 to dcadb21 Compare

April 22, 2025 17:09

ecdsa marked this pull request as ready for review

April 22, 2025 17:13

ecdsa force-pushed the txbatcher_without_password_in_memory branch from 4286797 to eaa0f14 Compare

April 23, 2025 07:19

f321x reviewed

View reviewed changes

electrum/gui/qt/main_window.py Outdated Show resolved Hide resolved

f321x reviewed

View reviewed changes

electrum/gui/qt/main_window.py Outdated Show resolved Hide resolved

f321x reviewed

View reviewed changes

electrum/gui/qt/main_window.py Outdated Show resolved Hide resolved

f321x reviewed

View reviewed changes

electrum/gui/qt/main_window.py Outdated Show resolved Hide resolved

f321x reviewed

View reviewed changes

electrum/gui/qt/main_window.py Outdated

    
                          else:

                              future.cancel()

                      self.take_action_button.clicked.connect(on_clicked)

                      self.take_action_button.show()

Member

f321x Apr 23, 2025

Showing a notification could improve users response to the prompt:
self.notify(_('Password required to') + f': {reason}')

accumulator reviewed

View reviewed changes

electrum/gui/qt/main_window.py Outdated Show resolved Hide resolved

ecdsa marked this pull request as draft

April 23, 2025 12:54

ecdsa force-pushed the txbatcher_without_password_in_memory branch 3 times, most recently from 3d81aa1 to f616cb9 Compare

April 25, 2025 15:09

ecdsa force-pushed the txbatcher_without_password_in_memory branch 4 times, most recently from 02ff419 to 166f3b1 Compare

May 4, 2025 09:50

ecdsa marked this pull request as ready for review

May 4, 2025 09:50

f321x reviewed

View reviewed changes

electrum/gui/qt/main_window.py Outdated Show resolved Hide resolved

f321x reviewed

View reviewed changes

electrum/gui/qt/main_window.py Outdated Show resolved Hide resolved

ecdsa force-pushed the txbatcher_without_password_in_memory branch 2 times, most recently from 6746a1c to e51f6c9 Compare

May 5, 2025 10:01

SomberNight reviewed

View reviewed changes

electrum/transaction.py Show resolved Hide resolved

ecdsa force-pushed the txbatcher_without_password_in_memory branch 3 times, most recently from 32e4311 to b981f41 Compare

May 6, 2025 10:38

ecdsa added 2 commits

May 6, 2025 13:04


          Qt: do not require password in memory

07ba0e6

 - do not require full encryption
 - do not store password on startup
 - add lock/unlock functions to qt GUI


          txbatcher: do not require password in memory

7bcc7fb

 - if password is needed, await future and request it from GUI
 - run asyncio task for each TxBatch, so that batches can
   request the password concurrently

ecdsa force-pushed the txbatcher_without_password_in_memory branch from b981f41 to 7bcc7fb Compare

May 6, 2025 11:05

ecdsa merged commit a4d88e3 into master

0 of 13 checks passed

ecdsa deleted the txbatcher_without_password_in_memory branch

May 6, 2025 11:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet