plugins: add functionality to allow setting plugin pubkey from gui #9765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f321x
force-pushed
the
plugin_pubk_user_prompt
branch
2 times, most recently
from
1b7edb9 to
a5c91fd
Compare
Adds functionality that allows the user to store the plugin authorization pubkey without having to edit files/registry manually. On Linux systems it spawns the commands in a subprocess with pkexec which will trigger a OS prompt to execute the commands as root. The user sees the executed commands and can either authorize with the root password or decline. On windows it uses the windows `ShellExecuteExW` api to edit the registry, this also triggers a OS dialog to accept or decline (UAC dialog). There is also functionality to reset the key again, which works in the same way.
f321x
force-pushed
the
plugin_pubk_user_prompt
branch
from
a5c91fd to
08927bb
Compare
SomberNight
reviewed
May 7, 2025
| """ | ||
| from winreg import ConnectRegistry, OpenKey, QueryValue, HKEY_LOCAL_MACHINE | ||
|
|
||
| key_path = r'HKEY_LOCAL_MACHINE\SOFTWARE\Electrum\PluginsKey' |
There was a problem hiding this comment.
can this be deduped somehow with self.keyfile_windows?
| auto_setup_btn = QPushButton(_('Try Auto-Setup')) | ||
| def on_auto_setup_clicked(): | ||
| if not self.plugins.try_auto_key_setup(key_hex): | ||
| self.show_error(_("Auto-Setup not possible. Try the manual setup.")) |
There was a problem hiding this comment.
ideally we should still show the manual setup instructions if this happens, but the popup gets closed
There was a problem hiding this comment.
(btw at the same time, we should probably improve the manual instructions, e.g. for Linux, write copy-pasteable and readable commands, such as:
$ sudo sh -c 'echo "015d0f863d213e7bd4549ec45d1155d43268b7dd5387728936e5a937346d53b3fe02f8495dabc5111401d7a5b897ccb11c34f3dc6b51afeff637d55efe61aa75edf3" > /etc/electrum/plugins_key'
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality that allows the user to store the plugin authorization pubkey without having to edit files/registry manually. On Linux systems it spawns the commands in a subprocess with polkits pkexec which will trigger an OS prompt to execute the commands as root. The user sees the executed commands and can either authorize with the root password or decline.
On windows it uses the windows
ShellExecuteExWapi execute reg.exe with elevated permissions to edit the registry, this also triggers an OS dialog the user can accept or decline (UAC dialog).There is also functionality to reset the key again, which works in the same way.
I tested this from source on both plattforms and as AppImage and Windows installer.
This won't work on MacOS (no pkexec), would need access to a Mac to implement a similar solution.
The windows OS prompt:
The Linux (KDE) prompt: