qt: add qr reading from file to ScanQRTextEdit and SendTab #9782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no ability to read qr codes contained in image files. This is confusing in some contexts, as
on_file_input()
of ScanQRTextEdit will read the whole content of the file (instead of looking for qr codes).The revealer plugin for example generates png files containing qr codes and uses the
ScanQRTextEdit
to get user input, for the user it would seem logical to click on 'Read from file' to load the generated file, however this will result in the wrong data getting loaded. Having the option to explicitly load a QR from file makes this clear.Besides that it seems useful, considering reading QR from screenshots doesn't work on wayland.