Skip to content

Improve logging around reading and merging config files #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chancez wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −3
Open

Improve logging around reading and merging config files #2106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions viper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1580,7 +1580,7 @@ func ReadInConfig() error { return v.ReadInConfig() }
// ReadInConfig will discover and load the configuration file from disk
// and key/value stores, searching in one of the defined paths.
func (v *Viper) ReadInConfig() error {
v.logger.Info("attempting to read in config file")
v.logger.Debug("attempting to read in config file")
filename, err := v.getConfigFile()
if err != nil {
return err
Expand All @@ -1590,7 +1590,7 @@ func (v *Viper) ReadInConfig() error {
return UnsupportedConfigError(v.getConfigType())
}

v.logger.Debug("reading file", "file", filename)
v.logger.Info("reading file", "file", filename)

file, err := afero.ReadFile(v.fs, filename)
if errors.Is(err, fs.ErrNotExist) {
Expand All @@ -1617,7 +1617,7 @@ func MergeInConfig() error { return v.MergeInConfig() }

// MergeInConfig merges a new configuration with an existing config.
func (v *Viper) MergeInConfig() error {
v.logger.Info("attempting to merge in config file")
v.logger.Debug("attempting to merge in config file")
filename, err := v.getConfigFile()
if err != nil {
return err
Expand All @@ -1627,6 +1627,8 @@ func (v *Viper) MergeInConfig() error {
return UnsupportedConfigError(v.getConfigType())
}

v.logger.Info("merging file into config", "file", filename)

file, err := afero.ReadFile(v.fs, filename)
if err != nil {
return err
Expand Down
Loading