Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError: Some type variables (...) are not listed in Generic[...] #12850

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix TypeError: Some type variables (...) are not listed in Generic[...] #12850

wants to merge 3 commits into from

Conversation

IkorJefocur
Copy link

Feature or Bugfix

  • Bugfix

Purpose

Closes: #12797

Detail

Relates

None

AA-Turner
AA-Turner reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you add a test?

@jayaddison
Copy link
Contributor

Adding or expanding a test project -- these can be found under the tests/roots directory -- would be helpful to get this merged, to confirm the problem and prevent accidental regressions in future.

@jayaddison
Copy link
Contributor

(oops - that was duplicative feedback. even so, test coverage for this would be a great help)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

Assignees
No one assigned
Labels
domains:py
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Some type variables (...) are not listed in Generic[...]
3 participants
@IkorJefocur @jayaddison @AA-Turner