Fix test_gettext_literalblock_additional to use the correct test root - #14507
Open
befeleme wants to merge 2 commits into
Open
Fix test_gettext_literalblock_additional to use the correct test root#14507befeleme wants to merge 2 commits into
befeleme wants to merge 2 commits into
Conversation
test-root doesn't contain the source file for literalblock.pot. The test passed sequentially because other tests using test root 'intl' left the file in the same srcdir. With pytest-xdist, the test started correctly failing, as no leftover file was available during the test run. Using the test root 'intl', which contains literalblock.txt, fixes the test.
jdillard
approved these changes
Jul 23, 2026
jdillard
left a comment
jdillard
left a comment
Member
There was a problem hiding this comment.
Reusing srcdir='gettext' lets earlier tests contaminate that directory, explaining why sequential runs passed. This fix makes the test self-contained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
test-root doesn't contain the source file for literalblock.pot. The test passed sequentially because other tests using test root 'intl' left the file in the same srcdir. With pytest-xdist, the test started correctly failing, as no leftover file was available during the test run. Using the test root 'intl', which contains literalblock.txt, fixes the test.
References
Fixes #14506
AI Disclosure
I used claude code to debug why the test passes sequentially but not in parallel run. I have verified that the finding: incorrect test root, is indeed the issue happening and that the fix indeed fixes the issue observed in Fedora.