You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This follows up on #14100, which intended to isolate test_numfig_disabled_warn but changed the wrong tests and was subsequently reverted in #14106.
It also fixes #14104 and addresses the numfig flakiness mentioned in #13996, but doesn't close that broader issue.
Fix analysis
test_numfig_disabled_warn only checks that a build emits the “numfig is disabled” warning. It was marked with shared_result='test_build_html_numfig', same as the nearby HTML output tests, so they reuse one build for speed.
Unfortunately, the sharing is wrong for a warning assertion. With shared_result, if another test already built (or artifacts exist while the in-memory restore is empty), the app can skip rebuilding. Then app.warning stays empty and the assert fails intermittently under parallel CI, depending on which shared-result test runs the build first.
FAILED tests/test_builders/test_build_html_numfig.py::test_numfig_disabled_warn - AssertionError: assert 'index.rst:47: WARNING: numfig is disabled. :numref: is ignored.' in ''
This PR drops shared_result from that one test so it always does a fresh build and owns its warning stream. The other numfig tests can keep sharing; they only check HTML, not warnings.
The test_numfig_disabled_warn flaked on the Docutils HEAD job in #14574 after I merged in the two recent CI fixes. Seems like this PR would help to make CI even greener.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checks
pytest -q tests/test_builders/test_build_html_numfig.pyFixes #14104