Skip to content

Add poll_now_notify parameter to poll_loop and on_work_available callback#12

Merged
phillipleblanc merged 1 commit into
spiceai-51from
phillip/260126-poll-loop-interrupt
Jan 26, 2026
Merged

Add poll_now_notify parameter to poll_loop and on_work_available callback#12
phillipleblanc merged 1 commit into
spiceai-51from
phillip/260126-poll-loop-interrupt

Conversation

@phillipleblanc
Copy link
Copy Markdown

  • Add poll_now_notify: Option<Arc> parameter to poll_loop in execution_loop.rs
  • Update idle sleep to use tokio::select! - wakes on 100ms timeout OR notify signal
  • Add OnWorkAvailableFn callback type and field to SchedulerConfig
  • Invoke callback after JobSubmitted and TaskUpdating events when new work available
  • Update standalone executor and executor_process to pass None for poll_now_notify

…back

- Add poll_now_notify: Option<Arc<Notify>> parameter to poll_loop in execution_loop.rs
- Update idle sleep to use tokio::select! - wakes on 100ms timeout OR notify signal
- Add OnWorkAvailableFn callback type and field to SchedulerConfig
- Invoke callback after JobSubmitted and TaskUpdating events when new work available
- Update standalone executor and executor_process to pass None for poll_now_notify
@phillipleblanc phillipleblanc force-pushed the phillip/260126-poll-loop-interrupt branch from e0ab27e to 6088cdb Compare January 26, 2026 07:03
@phillipleblanc phillipleblanc merged commit d827769 into spiceai-51 Jan 26, 2026
29 checks passed
@phillipleblanc phillipleblanc deleted the phillip/260126-poll-loop-interrupt branch January 26, 2026 18:43
@milenkovicm
Copy link
Copy Markdown

Hey @phillipleblanc I've noticed you guys are doing great job extending ballista, would you consider contributing patches back to ballista for things like #12, #13, #14, #15 ?

@milenkovicm
Copy link
Copy Markdown

Also, it would be great if could get involved into steering ballista's direction

@phillipleblanc
Copy link
Copy Markdown
Author

@milenkovicm Yes! We can definitely upstream some of the work we've been doing. What would be the best way to start participating in steering ballista's direction?

@milenkovicm
Copy link
Copy Markdown

cool! if ok, i would cherry pick few commits from your repo an back-port them to ballista, will add you do PR review. also, feel free to suggest things needed on master

with regards to ballista steering participations, whatever you guys have bandwidth to do, even just opening bugs or keeping an eye on PR would be appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants