fix: preserve parquet metadata size hint#29
Merged
Conversation
peasee
commented
Apr 21, 2026
peasee
commented
- Ensures that the parquet metadata size hint is preserved during distributed plan de/serialization.
- Without the metadata size hint set, it defaults to no size hint - causing 2 requests instead of 1 (1 to get the size, 1 to retrieve the metadata vs just 1 to retrieve the metadata)
There was a problem hiding this comment.
Pull request overview
This PR addresses a performance regression in distributed query execution by restoring Parquet metadata size hint information after the physical plan is deserialized from protobuf, avoiding extra object-store HTTP round trips when reading Parquet metadata.
Changes:
- Add a plan-tree rewrite that rehydrates
ParquetSource.metadata_size_hintfromTableParquetOptionsafter protobuf round-trip. - Apply this rewrite at the start of executor stage creation so downstream Parquet reads benefit automatically.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
phillipleblanc
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.