forked from apache/datafusion-ballista
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: distributed EXPLAIN / EXPLAIN ANALYZE via logical extension codec #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,6 +38,28 @@ message BallistaPhysicalPlanNode { | |
| } | ||
| } | ||
|
|
||
| /////////////////////////////////////////////////////////////////////////////////////////////////// | ||
| // Ballista Logical Plan extensions | ||
| /////////////////////////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| // Ballista wrapper around datafusion Explain logical plan node. | ||
| // Used to preserve `explain_format` across the client -> scheduler boundary | ||
| // because the datafusion-proto `ExplainNode` does not encode that field. | ||
| message BallistaExplainNode { | ||
| bool verbose = 1; | ||
| // One of: "indent", "tree", "pgjson", "graphviz" | ||
| string explain_format = 2; | ||
| } | ||
|
|
||
| // Discriminating wrapper encoded as the payload of a Ballista logical | ||
| // extension node. Allows a single codec entry point to route to the | ||
| // appropriate Ballista logical extension type. | ||
| message BallistaLogicalExtensionNode { | ||
| oneof node { | ||
| BallistaExplainNode explain = 1; | ||
| } | ||
| } | ||
|
|
||
| message ShuffleWriterExecNode { | ||
| //TODO it seems redundant to provide job and stage id here since we also have them | ||
| // in the TaskDefinition that wraps this plan | ||
|
|
@@ -606,6 +628,27 @@ message GetJobStatusParams { | |
| string job_id = 1; | ||
| } | ||
|
|
||
| message GetJobMetricsParams { | ||
| string job_id = 1; | ||
| } | ||
|
|
||
| message JobStageMetrics { | ||
| uint32 stage_id = 1; | ||
| uint32 partitions = 2; | ||
| repeated OperatorWithMetrics operators = 3; | ||
| } | ||
|
|
||
| message OperatorWithMetrics { | ||
| uint32 depth = 1; | ||
| string operator_type = 2; | ||
| string operator_desc = 3; | ||
| repeated OperatorMetric metrics = 4; | ||
| } | ||
|
|
||
| message GetJobMetricsResult { | ||
| repeated JobStageMetrics stages = 1; | ||
| } | ||
|
|
||
| message SuccessfulJob { | ||
| repeated PartitionLocation partition_location = 1; | ||
| uint64 queued_at = 2; | ||
|
|
@@ -799,6 +842,8 @@ service SchedulerGrpc { | |
|
|
||
| rpc GetJobStatus (GetJobStatusParams) returns (GetJobStatusResult) {} | ||
|
|
||
| rpc GetJobMetrics (GetJobMetricsParams) returns (GetJobMetricsResult) {} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems unrelated to the explain changes? |
||
|
|
||
| // Used by Executor to tell Scheduler it is stopped. | ||
| rpc ExecutorStopped (ExecutorStoppedParams) returns (ExecutorStoppedResult) {} | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.