forked from datafusion-contrib/datafusion-federation
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add EXPLAIN and EXPLAIN ANALYZE support to federated queries #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lukekim
wants to merge
12
commits into
spiceai-52
Choose a base branch
from
lukim/explain
base: spiceai-52
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
02a0b3c
feat: Add EXPLAIN and EXPLAIN ANALYZE support to federated queries
lukekim 69733b8
Merge remote-tracking branch 'origin/spiceai-50' into lukim/explain
lukekim bff287a
Formatting
lukekim 12c3739
feat: Add EXPLAIN and EXPLAIN ANALYZE support to federated queries
lukekim fa8a410
Merge branch 'spiceai-50' into lukim/explain
lukekim 0dea595
chore: apply rustfmt
lukekim d653c52
Merge remote-tracking branch 'origin/main' into lukim/explain
lukekim 6599d31
feat: Add EXPLAIN and EXPLAIN ANALYZE support to federated queries
lukekim a8b4c1d
Merge remote-tracking branch 'origin/spiceai-52' into lukim/explain
lukekim a0a9090
fix: realign explain changes to spiceai-52
lukekim 9e0b9d6
fix: preserve explain directives in federated SQL
lukekim 990536b
test: assert explain final sql directly
lukekim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FederatedQueryPlanner::create_physical_plannow always clones the entireLogicalPlanbecauseannotate_query_directivesreturnsplan.clone()for the non-EXPLAIN/ANALYZE case. This adds an avoidable allocation/copy on every query. Consider only callingannotate_query_directives(and only allocating a new plan) when the root isLogicalPlan::Explain/LogicalPlan::Analyze; otherwise pass the originallogical_planthrough tocreate_physical_plan.