Fix Explain Analyze#66
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes federated EXPLAIN ANALYZE by ensuring federation does not wrap LogicalPlan::Analyze, so DataFusion’s AnalyzeExec can collect metrics while only the inner query is federated.
Changes:
- Skip calling the federation provider analyzer when the current plan node is
LogicalPlan::Analyze(_), preventing top-level federation ofEXPLAIN ANALYZE. - Add a regression test asserting the root logical node remains
Analyze, the inner query contains aFederatednode, and physical planning producesAnalyzeExec.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
datafusion-federation/src/analyzer/mod.rs |
Prevents federation of LogicalPlan::Analyze nodes by bypassing provider-level federation at that node and allowing child federation instead. |
datafusion-federation/src/sql/mod.rs |
Adds a regression test to validate EXPLAIN ANALYZE is planned/executed correctly with federation only on the inner query. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lukekim
approved these changes
Mar 27, 2026
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
Fix
EXPLAIN ANALYZEon federated queries by preventing the federation analyzer from wrappingAnalyzeplan nodes, allowing only the inner query to be federated while DataFusion'sAnalyzeExechandles metrics collection.