Skip to content

fix: Correct pg_sslmode default from verify-full to prefer#1543

Merged
lukekim merged 1 commit into
trunkfrom
fix/pg-sslmode-default
Apr 21, 2026
Merged

fix: Correct pg_sslmode default from verify-full to prefer#1543
lukekim merged 1 commit into
trunkfrom
fix/pg-sslmode-default

Conversation

@claudespice
Copy link
Copy Markdown
Collaborator

Summary

  • The pg_sslmode parameter documentation incorrectly states the default is verify-full
  • The actual default is prefer, matching standard libpq/tokio-postgres behavior
  • When no sslmode is specified, the client tries TLS but falls back to plaintext

Details

For the replication (CDC) path, SslMode::from_str_or_default() explicitly defaults to Prefer in crates/data_components/src/postgres_replication/config.rs. For the read path, no sslmode default is set in the ParameterSpec, so the underlying tokio-postgres library applies its own default of prefer.

Changes

  • Moved (default) label from verify-full to prefer in the pg_sslmode parameter table
  • Fixed across all versioned docs (1.5.x–1.11.x) and vNext (8 files total)

Reference

Verified against spiceai/spiceai at trunkpostgres_replication/config.rs:88-96

The documentation incorrectly states that the default value of
pg_sslmode is verify-full. The actual default is prefer, which
matches standard libpq/tokio-postgres behavior — when no sslmode
is specified, the client tries TLS but falls back to plaintext.

For the replication (CDC) path, SslMode::from_str_or_default()
explicitly defaults to Prefer (postgres_replication/config.rs).
For the read path, no sslmode default is set in the ParameterSpec,
so the underlying tokio-postgres library applies its own default
of prefer.

Fixed across all versioned docs (1.5.x–1.11.x) and vNext.
@claudespice claudespice added bug Something isn't working area/docs labels Apr 21, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

✅ Pull with Spice Passed

Passing checks:

  • ✅ Title meets minimum length requirement (10 characters)
  • ✅ Has at least one of the required labels: area/blog, area/docs, area/cookbook, dependencies
  • ✅ No banned labels detected
  • ✅ Has at least one assignee: lukekim

@github-actions
Copy link
Copy Markdown

🔍 Pull with Spice Failed

Passing checks:

  • ✅ Title meets minimum length requirement (10 characters)
  • ✅ Has at least one of the required labels: area/blog, area/docs, area/cookbook, dependencies
  • ✅ No banned labels detected

Failed checks:

  • ❌ At least one assignee is required for this pull request.

Please address these issues and update your pull request.

1 similar comment
@github-actions
Copy link
Copy Markdown

🔍 Pull with Spice Failed

Passing checks:

  • ✅ Title meets minimum length requirement (10 characters)
  • ✅ Has at least one of the required labels: area/blog, area/docs, area/cookbook, dependencies
  • ✅ No banned labels detected

Failed checks:

  • ❌ At least one assignee is required for this pull request.

Please address these issues and update your pull request.

@github-actions
Copy link
Copy Markdown

🚀 deployed to https://1692aca1.spiceai-org-website.pages.dev

@lukekim lukekim self-assigned this Apr 21, 2026
@lukekim lukekim merged commit 789f138 into trunk Apr 21, 2026
6 of 11 checks passed
@lukekim lukekim deleted the fix/pg-sslmode-default branch April 21, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants