fix: Correct pg_sslmode default from verify-full to prefer#1543
Merged
Conversation
The documentation incorrectly states that the default value of pg_sslmode is verify-full. The actual default is prefer, which matches standard libpq/tokio-postgres behavior — when no sslmode is specified, the client tries TLS but falls back to plaintext. For the replication (CDC) path, SslMode::from_str_or_default() explicitly defaults to Prefer (postgres_replication/config.rs). For the read path, no sslmode default is set in the ParameterSpec, so the underlying tokio-postgres library applies its own default of prefer. Fixed across all versioned docs (1.5.x–1.11.x) and vNext.
✅ Pull with Spice PassedPassing checks:
|
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
1 similar comment
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
|
🚀 deployed to https://1692aca1.spiceai-org-website.pages.dev |
lukekim
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pg_sslmodeparameter documentation incorrectly states the default isverify-fullprefer, matching standard libpq/tokio-postgres behaviorDetails
For the replication (CDC) path,
SslMode::from_str_or_default()explicitly defaults toPreferincrates/data_components/src/postgres_replication/config.rs. For the read path, no sslmode default is set in theParameterSpec, so the underlyingtokio-postgreslibrary applies its own default ofprefer.Changes
(default)label fromverify-fulltopreferin thepg_sslmodeparameter tableReference
Verified against spiceai/spiceai at
trunk— postgres_replication/config.rs:88-96