fix: Note scylladb_ssl parameter is not yet implemented#1544
Merged
Conversation
The scylladb_ssl parameter is defined in the ParameterSpec but never read or applied in the session builder code. The parameter is accepted without error but has no effect on the connection. Added a note to the parameter description in both vNext and 1.11.x docs.
✅ Pull with Spice PassedPassing checks:
|
|
🚀 deployed to https://5ac4688c.spiceai-org-website.pages.dev |
lukekim
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scylladb_sslparameter is defined in theParameterSpecarray but never read or applied during session builder configurationscylladb_ssl: truewill not get SSL/TLS connections — the parameter is silently ignoredChanges
scylladb_ssldescription clarifying the parameter has no effectReference
Verified against spiceai/spiceai at
trunk—scylladb_sslis defined at connector-scylladb/src/lib.rs:129-131 but never retrieved viaparams.get("ssl")in thecreate_scylladb_connector()function (lines 324-447).