Skip to content

fix: Correct swapped metric types in Postgres deployment guide#1659

Merged
lukekim merged 1 commit into
trunkfrom
fix/postgres-metric-types
May 6, 2026
Merged

fix: Correct swapped metric types in Postgres deployment guide#1659
lukekim merged 1 commit into
trunkfrom
fix/postgres-metric-types

Conversation

@claudespice
Copy link
Copy Markdown
Collaborator

Summary

  • Fix swapped metric types for replication_bootstrap_rows_total and replication_bootstrap_complete in the Postgres deployment guide metrics table.
  • Per the source implementation (connector-postgres/src/replication.rs), replication_bootstrap_rows_total uses ObservableCounterU64 and replication_bootstrap_complete uses ObservableGaugeU64. The docs had these two types reversed.

Test plan

  • Verify the metrics table in the Postgres deployment guide renders correctly
  • Confirm metric types match the implementation in spiceai/spiceai

The metric types for `replication_bootstrap_rows_total` and
`replication_bootstrap_complete` were swapped. Per the source
implementation, `replication_bootstrap_rows_total` is an
ObservableCounter (not ObservableGauge) and
`replication_bootstrap_complete` is an ObservableGauge (not
ObservableCounter).
@claudespice claudespice added bug Something isn't working area/docs labels May 6, 2026
@claudespice claudespice self-assigned this May 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

🔍 Pull with Spice Failed

Passing checks:

  • ✅ Title meets minimum length requirement (10 characters)
  • ✅ Has at least one of the required labels: area/blog, area/docs, area/cookbook, dependencies
  • ✅ No banned labels detected

Failed checks:

  • ❌ At least one assignee is required for this pull request.

Please address these issues and update your pull request.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

🚀 deployed to https://76bc9d81.spiceai-org-website.pages.dev

@lukekim lukekim merged commit 98a0849 into trunk May 6, 2026
8 of 11 checks passed
@lukekim lukekim deleted the fix/postgres-metric-types branch May 6, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants