Skip to content

fix: Correct ScyllaDB connector filter pushdown docs#1664

Merged
lukekim merged 1 commit into
trunkfrom
fix/scylladb-filter-pushdown-docs
May 6, 2026
Merged

fix: Correct ScyllaDB connector filter pushdown docs#1664
lukekim merged 1 commit into
trunkfrom
fix/scylladb-filter-pushdown-docs

Conversation

@claudespice
Copy link
Copy Markdown
Collaborator

Summary

  • The ScyllaDB connector docs incorrectly stated that filter pushdown was entirely disabled. The actual implementation pushes down partition key equality (=) and clustering key comparison (=, <, <=, >, >=) filters to CQL.
  • Replaced the "Why Filter Pushdown is Disabled" section with an accurate "Filter Pushdown" section describing Exact (partition key) and Inexact (clustering key) pushdown behavior, plus a table of what is/isn't pushed down.
  • Removed misleading "by default" from the batch size description (8192 is hardcoded, not configurable).
  • Updated the Performance Considerations section to note that partition/clustering key filters reduce data transfer.
  • Updated the CQL Limitations section to accurately describe which WHERE clause filters are pushed down.
  • Applied the same fix to both website/docs/ (vNext) and website/versioned_docs/version-1.11.x/.

Test plan

  • Verify the vNext ScyllaDB docs page renders correctly with the new filter pushdown table
  • Verify the v1.11.x ScyllaDB docs page renders correctly with the same changes
  • Confirm no other sections (params, types, examples) were modified

The docs incorrectly stated that filter pushdown was entirely disabled
and all data was fetched via SELECT * queries. The actual implementation
pushes down partition key equality filters (Exact) and clustering key
comparison filters (Inexact, when partition key is present). Updated
both vNext and v1.11.x docs to accurately describe the pushdown
behavior, fixed the misleading "by default" on batch size (it is
hardcoded), and corrected the Performance Considerations and Limitations
sections.
@claudespice claudespice added bug Something isn't working area/docs labels May 6, 2026
@claudespice claudespice self-assigned this May 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

🔍 Pull with Spice Failed

Passing checks:

  • ✅ Title meets minimum length requirement (10 characters)
  • ✅ Has at least one of the required labels: area/blog, area/docs, area/cookbook, dependencies
  • ✅ No banned labels detected

Failed checks:

  • ❌ At least one assignee is required for this pull request.

Please address these issues and update your pull request.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

🚀 deployed to https://70d16bc1.spiceai-org-website.pages.dev

@lukekim lukekim merged commit b94825d into trunk May 6, 2026
6 of 9 checks passed
@lukekim lukekim deleted the fix/scylladb-filter-pushdown-docs branch May 6, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants