fix: Correct pg_sslrootcert inline PEM claim and min_idle pool behavior#1665
Merged
Conversation
…behavior Remove the undocumented inline PEM content claim from pg_sslrootcert descriptions across both the data connector and data accelerator docs. The runtime code treats the value as a file path only — the inline PEM detection logic was never implemented. Also correct the data connector's min_idle vs pool size documentation: the bb8 connection pool silently caps min_idle at max_size rather than rejecting the configuration at startup (the startup rejection only applies to the accelerator's deadpool pool).
✅ Pull with Spice PassedPassing checks:
|
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
lukekim
approved these changes
May 6, 2026
|
🚀 deployed to https://5702a762.spiceai-org-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove inline PEM claim from
pg_sslrootcert: The parameter description in both data connector and data accelerator docs claimed that values starting with-----BEGINare treated as inline PEM content. This was never implemented — the runtime code (postgrespool.rs) treats the value strictly as a file path viastd::path::Path::new(...).exists(), and the replication path stores it asPathBuf::from(...). The claim was introduced by PR #10578 which only updated theParameterSpecdescription text without adding the corresponding parsing logic.Fix min_idle validation behavior for data connector: The data connector deployment guide stated that
pg_connection_pool_min_idle > connection_pool_sizeis "rejected as configuration errors at startup." This is only true for the Postgres accelerator (which uses deadpool). The data connector uses bb8, which silently capsmin_idleatmax_size. Updated the description and troubleshooting table to reflect the actual silent-cap behavior.Files changed
website/docs/components/data-connectors/postgres/index.mdpg_sslrootcertdescriptionwebsite/docs/components/data-connectors/postgres/deployment.mdwebsite/docs/components/data-accelerators/postgres/index.mdpg_sslrootcertdescriptionwebsite/docs/components/data-accelerators/postgres/deployment.mdpg_sslrootcerttable cellNo versioned docs required changes — the inline PEM claim exists only in vNext, and no versioned
deployment.mdexists for the Postgres connector.Test plan
pg_sslrootcertdescriptions no longer mention inline PEM content