fix: Correct Iceberg DELETE support status and dead s3_connect_timeout param#1670
Merged
Merged
Conversation
The Redshift docs incorrectly claimed pg_port defaults to 5439. The Postgres connector code has no .default() call on the port parameter, so the underlying tokio-postgres default of 5432 applies. Port 5439 is Redshift's standard port but not a Spice-level default. Updated the description across all doc versions to clarify that users should set this value explicitly. Also added the missing `disable` and `allow` values to the pg_sslmode parameter description in the vNext docs, matching the code's one_of constraint.
…t param - DELETE FROM is now supported via equality delete files (implemented in IcebergDeletionProvider). Update the Write Support section to reflect this; only UPDATE remains unsupported. - Add a note to iceberg_s3_connect_timeout documenting that the parameter is accepted but currently has no effect (it is not mapped in map_param_name_to_iceberg_prop nor read directly by any code path).
✅ Pull with Spice PassedPassing checks:
|
|
🚀 deployed to https://e5c162c3.spiceai-org-website.pages.dev |
lukekim
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UPDATEandDELETEoperations are not supported. This is no longer accurate —DELETE FROMis implemented via equality delete files (crates/data_components/src/iceberg/delete.rs) and tables are wrapped inIcebergDeletionProviderviaread_write_providerin the runtime. OnlyUPDATEremains unsupported.iceberg_s3_connect_timeoutis a dead parameter: The parameter is documented with a default of60but is never consumed — it is not mapped inmap_param_name_to_iceberg_propand is not read directly by any code path. Added a note clarifying this has no effect.Changes are limited to the vNext docs (
website/docs/components/data-connectors/iceberg.md). Versioned docs (1.5.x–1.11.x) do not contain a Write Support section or any DELETE/UPDATE statement, so no changes are needed there.Test plan
s3_connect_timeoutnote addition