fix: Remove Map from Cayenne unsupported types list#1672
Merged
Conversation
Map types are supported by Cayenne (Vortex). The source code in schema.rs only lists Interval, Duration, and FixedSizeBinary as unsupported types. A test (test_transform_schema_for_vortex_preserves_http_response_headers_map) explicitly verifies that Map types pass through correctly. This fix removes Map from the unsupported types list and adds it to the fully supported types list in vNext, 1.11.x, and 1.10.x docs.
✅ Pull with Spice PassedPassing checks:
|
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
|
🚀 deployed to https://b23e434a.spiceai-org-website.pages.dev |
lukekim
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mapfrom the Cayenne "Unsupported Types" list and "Limitations" section across vNext, 1.11.x, and 1.10.x docsMapsto the "Fully Supported Types" list in vNext and 1.11.x (1.10.x does not have this section)The Cayenne accelerator docs incorrectly listed
Maptypes as unsupported. The source code atcrates/cayenne/src/schema.rs(lines 23-27) only listsInterval,Duration, andFixedSizeBinaryas unsupported types. Additionally, the testtest_transform_schema_for_vortex_preserves_http_response_headers_mapatcrates/runtime/src/dataaccelerator/cayenne/mod.rs(line 2037) explicitly verifies that Map types pass through correctly.Test plan
Mapno longer appears in the "Unsupported Types" section of any Cayenne docMapsappears in the "Fully Supported Types" list in vNext and 1.11.xgrep -rn "Map" website/ | grep -i "unsupported\|cayenne"and confirm only "Zone-Map Equivalent" and "Maps" (in supported list) remain