fix: Mark spark_remote parameter as Required in Spark connector docs#1674
Merged
Conversation
The spark_remote parameter is declared as .required() in the connector code (connector-spark/src/lib.rs), but the docs did not indicate this. Add "Required." to the spark_remote parameter description across vNext and all versioned docs (1.5.x-1.11.x).
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
|
🚀 deployed to https://439fb00f.spiceai-org-website.pages.dev |
lukekim
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spark_remoteparameter is declared as.required()in the Spark connector code (crates/data-connectors/connector-spark/src/lib.rsline 109), but the docs did not label it as Required.spark_remoteparameter description in the Configuration section across vNext and all versioned docs (1.5.x through 1.11.x).Test plan
spark_remoteshows "Required." in the Configuration section on vNext docsspark_remote