fix: Add missing sql_warehouse mode to Databricks v1.10.x and v1.11.x docs#1723
Merged
Conversation
… docs The versioned Databricks docs only listed spark_connect and delta_lake as valid modes, but sql_warehouse existed in both v1.10 and v1.11 releases. The mode parameter description, endpoint description, and client_timeout applicability were all incomplete.
✅ Pull with Spice PassedPassing checks:
|
|
🚀 deployed to https://3e2607e0.spiceai-org-website.pages.dev |
lukekim
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The versioned Databricks docs (v1.10.x and v1.11.x) only listed
spark_connectanddelta_lakeas validmodevalues, butsql_warehousemode existed in both releases. This is contradictory since the same page already documenteddatabricks_sql_warehouse_idreferencing sql_warehouse mode.Verified via
git show v1.10.0:crates/runtime/src/dataconnector/databricks.rsandgit show v1.11.6:crates/runtime/src/dataconnector/databricks.rs— both contain the"sql_warehouse"match arm andDatabricksSqlWarehouseconstructor.Changes
sql_warehouseto themodeparameter possible values list (v1.10.x and v1.11.x)databricks_endpointdescription from "Required for both modes" to "Required for all modes"client_timeoutfrom "Applicable only in delta_lake mode" to include sql_warehouse applicabilityFiles updated: 2 (version-1.10.x/databricks.md, version-1.11.x/databricks.md). Not applied to v1.9.x and earlier since sql_warehouse was introduced in v1.10.0.
Reference
Verified against spiceai/spiceai at
v1.10.0andv1.11.6—crates/runtime/src/dataconnector/databricks.rs.