Skip to content

Improve the SQL reference including Search functions#986

Merged
lukekim merged 31 commits into
trunkfrom
lukim/scalar-functions
Aug 20, 2025
Merged

Improve the SQL reference including Search functions#986
lukekim merged 31 commits into
trunkfrom
lukim/scalar-functions

Conversation

@lukekim
Copy link
Copy Markdown
Contributor

@lukekim lukekim commented May 7, 2025

  • Add proper index
  • Add Scalar Functions

lukekim added 2 commits May 7, 2025 13:13
- Add proper index
- Add Scalar Functions section
@lukekim lukekim self-assigned this May 7, 2025
@lukekim lukekim requested a review from Copilot May 7, 2025 20:20
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2025

✅ Pull with Spice Passed

Passing checks:

  • ✅ Title meets minimum length requirement (10 characters)
  • ✅ Has at least one of the required labels: area/blog, area/docs, area/cookbook, dependencies
  • ✅ No banned labels detected
  • ✅ Has at least one assignee: lukekim

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the SQL reference documentation by adding a dedicated SQL Reference index with scalar functions and a detailed table of contents while also cleaning up some outdated sections.

  • Updated the navbar to include a link to the SQL Reference documentation and adjusted the announcement bar version.
  • Removed outdated timestamp documentation and refined various SQL reference pages.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

File Description
website/docusaurus.config.ts Updated navbar links, announcement bar version changed, and removed the Community dropdown.
website/docs/reference/timestamp/index.md Removed the outdated Timestamps documentation.
website/docs/reference/sql/*.md Enhanced the SQL reference with a comprehensive table of contents and added Scalar Functions details.
Comments suppressed due to low confidence (2)

website/docusaurus.config.ts:118

  • [nitpick] The removal of the 'Community' dropdown from the navbar appears unrelated to the SQL documentation improvements; consider double-checking if this removal was intended.
Removal of the 'Community' dropdown

website/docusaurus.config.ts:93

  • The announcement bar's release version is updated to v1.2.0; please confirm that this change is intentional given the PR focus on SQL reference improvements.
content: '<a href="/blog/releases/v1.2.0">Spice.ai OSS v1.2.0</a> is now available! 🚀',

@lukekim lukekim added this to the v1.2.1 milestone May 7, 2025
phillipleblanc
phillipleblanc previously approved these changes May 8, 2025
kczimm
kczimm previously approved these changes May 8, 2025
@peasee peasee dismissed stale reviews from kczimm and phillipleblanc via aad40b0 May 12, 2025 22:40
Copy link
Copy Markdown
Contributor

@peasee peasee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sql/index.md contains links to page anchors and/or sections that don't exist.

sql/scalar_functions.md contains a reference to array_has as an alias, but array_has is not defined in this document.

@lukekim lukekim modified the milestones: v1.2.1, v1.3.0 May 19, 2025
@lukekim lukekim removed this from the v1.3.0 milestone Jul 22, 2025
@lukekim lukekim requested a review from peasee August 20, 2025 20:14
@github-actions
Copy link
Copy Markdown

🚀 deployed to https://51cc55bb.spiceai-org-website.pages.dev

@github-actions
Copy link
Copy Markdown

🚀 deployed to https://a6b8c2a8.spiceai-org-website.pages.dev

@lukekim lukekim changed the title Improve the SQL reference Improve the SQL reference including Search functions Aug 20, 2025
@github-actions
Copy link
Copy Markdown

🚀 deployed to https://62a8b712.spiceai-org-website.pages.dev

@github-actions
Copy link
Copy Markdown

🚀 deployed to https://2d81e0e0.spiceai-org-website.pages.dev

@lukekim lukekim merged commit 6012c6f into trunk Aug 20, 2025
6 checks passed
@lukekim lukekim deleted the lukim/scalar-functions branch August 20, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants