fix: resolve clippy warnings and formatting issues#33
Merged
Conversation
- Update BehaviorVersion::v2025_01_17 to ::latest() to fix deprecation warning - Add missing limit field to FileScanTask test constructors in reader.rs - Apply cargo fmt formatting fixes in row_delta.rs
There was a problem hiding this comment.
Pull request overview
This PR addresses Rust clippy warnings and formatting issues introduced during the iceberg-rust v0.9.0 merge work (PR #32), focusing on AWS SDK behavior version usage, test struct initialization correctness, and rustfmt cleanup.
Changes:
- Switch AWS SDK config initialization to
BehaviorVersion::latest()to resolve deprecation warnings. - Update
FileScanTasktest constructors to include the newlimitfield. - Apply
cargo fmtformatting adjustments inrow_deltatransaction tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crates/iceberg/src/transaction/row_delta.rs |
Rustfmt-driven formatting changes in tests (but currently introduces a compile error due to a missing semicolon). |
crates/iceberg/src/arrow/reader.rs |
Adds missing limit: None field in FileScanTask test constructors. |
crates/catalog/rest/src/middleware/sigv4.rs |
Updates AWS SDK behavior version to BehaviorVersion::latest() to avoid deprecation warnings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+270
to
+272
| assert!(matches!((&updates[0], &updates[1]), | ||
| (TableUpdate::AddSnapshot { snapshot }, TableUpdate::SetSnapshotRef { reference, ref_name }) | ||
| if snapshot.snapshot_id() == reference.snapshot_id && ref_name == MAIN_BRANCH) | ||
| ); | ||
| if snapshot.snapshot_id() == reference.snapshot_id && ref_name == MAIN_BRANCH)); |
There was a problem hiding this comment.
This assert!(matches!(...)) statement is missing a trailing semicolon, which will fail to compile because there are subsequent statements in the block. Add ; after the closing )).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix clippy warnings and formatting issues for PR #32: