feat: Add Parameterized Queries & Logging#37
Merged
Conversation
- rev version to v0.5 - add additional JDKs
lukekim
requested review from
peasee and
sgrebnov
and removed request for
sgrebnov
15 tasks
lukekim
changed the title
This was
linked to
issues
Jan 5, 2026
Closed
…available - TpchIntegrationTest: Check for tpch.customer table availability in setUp() - ParameterizedQueryTest: Skip on 'not found' errors in addition to connection errors - FlightQueryTest: Skip tests when API_KEY missing or taxi_trips table unavailable - Allows tests to pass in CI where specific test data may not exist
- testParameterizedQuerySpiceCloud now uses taxi_trips (available in CI) - TPC-H tests use tpch.* tables (available locally)
phillipleblanc
previously approved these changes
Jan 6, 2026
- FlightQueryTest and ParameterizedQueryTest now use explicit endpoints: - HTTP: https://us-west-2-prod-aws-data.spiceai.io - Flight: https://us-west-2-prod-aws-flight.spiceai.io:443
Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
Updated FlightQueryTest and ParameterizedQueryTest to use the standard Spice Cloud endpoints (data.spiceai.io and flight.spiceai.io) instead of region-specific URLs (us-east-1-prod-aws-* and us-west-2-prod-aws-*) which were causing 'failed to get spice client' errors.
krinart
previously approved these changes
Jan 6, 2026
phillipleblanc
previously approved these changes
Jan 6, 2026
Made exception handling case-insensitive and added null checks for error messages. The tests now skip gracefully when the acceleration is still loading initial data (common in CI environments).
krinart
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the release process documentation and CI workflows to improve version consistency, testing, and publishing reliability. It also updates the supported Java versions and introduces documentation for parameterized queries with strong type safety. The most important changes are summarized below:
Release Process & Documentation Improvements
.github/ISSUE_TEMPLATE/end_game.mdis expanded and reorganized for clarity, including new sections for code/version verification, documentation, testing, release, and post-release steps. Version checks, dependency updates, and community link verification are now explicitly required. [1] [2]0.5.0, and clarified the table of supported Java distributions and versions. [1] [2] [3]CI/CD Workflow Enhancements
pom.xmlandVersion.javain the publish workflow, and ensured tests are run before publishing. The workflow now uses a Maven cache and has a timeout and production environment set. [1] [2]