ci: define the test dataset inline instead of fetching it from the registry - #83
Merged
Merged
Conversation
…gistry `spice add spiceai/quickstart` makes every run depend on the Spicepod registry, which is currently returning a body the CLI cannot unpack: Invalid argument: Failed to extract Spicepod archive: invalid Zip archive: Could not find EOCD Declaring the same dataset inline removes the dependency. Covers both the Unix step (heredoc) and the Windows step (PowerShell here-string). Verified locally: taxi_trips loads and is queryable within seconds. Mirrors spicepy#176.
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow for the Rust SDK to avoid fetching the spiceai/quickstart Spicepod from the registry (currently failing to unpack) by declaring the equivalent dataset inline before starting the Spice runtime, so integration tests can run reliably again.
Changes:
- Replace
spice add spiceai/quickstartwith an inlinedatasets:declaration appended tospicepod.yamlon Unix (bash heredoc). - Do the same dataset injection on Windows (PowerShell here-string piped to
Add-Content). - Preserve the existing runtime start + wait behavior before running
cargo test.
This was referenced Aug 5, 2026
bjchambers
approved these changes
Aug 14, 2026
ewgenius
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces
spice add spiceai/quickstartwith the same dataset declared inline, in both the Unix step (heredoc) and the Windows step (PowerShell here-string).Why
Every
Build and testjob dies before a test runs:The Spicepod registry is returning a body the CLI can't unpack.
Clippyandrustfmtstay green because they don't need a runtime — only the jobs that start one fail, which is the signature of an environment problem rather than a code one.This reproduces off CI:
spice add spiceai/quickstartfails identically on a local machine.Mirrors spicepy#176, which is green.
Verification
taxi_tripsqueryable in ~6s, 2,964,624 rows'@at column 0 as PowerShell requiresspice initemitsversion: v2