Refactor: add explicit ParameterSpec for embedding components#10853
Open
ManishSharma1609 wants to merge 6 commits into
Open
Refactor: add explicit ParameterSpec for embedding components#10853ManishSharma1609 wants to merge 6 commits into
ManishSharma1609 wants to merge 6 commits into
Conversation
ManishSharma1609
changed the title
Contributor
✅ Pull with Spice PassedPassing checks:
|
ManishSharma1609
force-pushed
the
refactor/embedding-params-handling
branch
from
9583532 to
549360d
Compare
ManishSharma1609
force-pushed
the
refactor/embedding-params-handling
branch
3 times, most recently
from
adda819 to
cf60911
Compare
ManishSharma1609
changed the title
- Create crates/runtime/src/embeddings/params/ with per-provider ParameterSpec definitions for all 8 embedding providers (openai, azure, google, huggingface, databricks, bedrock, file, model2vec) - Update try_to_embedding to use Parameters::try_new with explicit specs - Update all provider function signatures from HashMap to Parameters - Remove unused extract_secret macro from embed.rs Closes spiceai#6755
ManishSharma1609
force-pushed
the
refactor/embedding-params-handling
branch
from
5528b24 to
0f91de8
Compare
Collaborator
|
@copilot review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6755
Summary
Replicates the approach from #6199 for embedding components. Adds explicit
ParameterSpecdefinitions for all 8 embedding providers instead of the free-formHashMap, and wires them throughParameters::try_newintry_to_embedding.Related
Closes #6755
Breaking Changes
None, existing embedding configurations continue to work. Unknown parameters will now emit a warning log instead of being silently ignored.
Docs
No doc changes required.
Notes for Reviewers
Tests added for all 8 embedding provider ParameterSpec definitions.
Followed the same pattern used in #6199 for model components.
Need help on this PR? Tag
@codesmithwith what you need.