Skip to content

Update setup and create_tables methods#77

Merged
lukekim merged 5 commits into
trunkfrom
lukim/schema
Feb 19, 2026
Merged

Update setup and create_tables methods#77
lukekim merged 5 commits into
trunkfrom
lukim/schema

Conversation

@lukekim
Copy link
Copy Markdown
Contributor

@lukekim lukekim commented Feb 19, 2026

This pull request updates the JSON-RPC protocol for system adapters to clarify and separate the responsibilities of the setup and create_tables methods. The main changes involve removing the datasets parameter from setup and moving it to create_tables, updating the protocol, documentation, and all affected references throughout the codebase and CI workflows.

Protocol and API changes:

  • The setup method now takes only run_id and metadata (no longer datasets), while create_tables now requires both run_id and datasets. This is reflected in the SetupRequest and CreateTablesRequest structs, as well as the client methods and example code. [1] [2] [3] [4] [5] [6] [7]

Documentation updates:

  • Updated the protocol documentation, README.md, and skill documentation to match the new method signatures and clarify the order and purpose of the setup and create_tables calls. [1] [2] [3] [4] [5] [6]

Codebase refactoring:

  • Renamed setup_request_datasets to create_tables_request_datasets in the pipeline code and updated all usages to reflect that datasets are now only required for create_tables. [1] [2] [3] [4]

CI and workflow adjustments:

  • Changed CI workflow jobs to use the updated JSON-RPC payloads: setup is now called without datasets, and create_tables is called with datasets, for all supported languages. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

@lukekim lukekim self-assigned this Feb 19, 2026
@lukekim lukekim enabled auto-merge (squash) February 19, 2026 01:45
@lukekim lukekim merged commit 5cbdb2a into trunk Feb 19, 2026
10 checks passed
@lukekim lukekim deleted the lukim/schema branch February 19, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants