Update setup and create_tables methods#77
Merged
Merged
Conversation
sgrebnov
approved these changes
Feb 19, 2026
peasee
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the JSON-RPC protocol for system adapters to clarify and separate the responsibilities of the
setupandcreate_tablesmethods. The main changes involve removing thedatasetsparameter fromsetupand moving it tocreate_tables, updating the protocol, documentation, and all affected references throughout the codebase and CI workflows.Protocol and API changes:
setupmethod now takes onlyrun_idandmetadata(no longerdatasets), whilecreate_tablesnow requires bothrun_idanddatasets. This is reflected in theSetupRequestandCreateTablesRequeststructs, as well as the client methods and example code. [1] [2] [3] [4] [5] [6] [7]Documentation updates:
README.md, and skill documentation to match the new method signatures and clarify the order and purpose of thesetupandcreate_tablescalls. [1] [2] [3] [4] [5] [6]Codebase refactoring:
setup_request_datasetstocreate_tables_request_datasetsin the pipeline code and updated all usages to reflect that datasets are now only required forcreate_tables. [1] [2] [3] [4]CI and workflow adjustments:
setupis now called withoutdatasets, andcreate_tablesis called withdatasets, for all supported languages. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]