Skip to content

Remove cleanup step from setup-spiceio action #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukekim merged 2 commits into from
Mar 30, 2026
Merged

Remove cleanup step from setup-spiceio action #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b63e7ff
Remove cleanup step from setup-spiceio action
lukekim Mar 30, 2026
d539327
Merge branch 'trunk' into fix/setup-action-no-cleanup
lukekim Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ outputs:
endpoint:
description: The S3-compatible endpoint URL
value: ${{ steps.start.outputs.endpoint }}
pid:
description: PID of the spiceio background process (empty if skipped)
value: ${{ steps.start.outputs.pid }}

runs:
using: composite
Expand Down Expand Up @@ -70,7 +67,6 @@ runs:
tar xzf "$ASSET" -C "$INSTALL_DIR"
chmod +x "$INSTALL_DIR/spiceio"
echo "$INSTALL_DIR" >> "$GITHUB_PATH"
echo "pid_file=${RUNNER_TEMP}/spiceio.pid" >> "$GITHUB_OUTPUT"

- name: Start spiceio
id: start
Expand All @@ -85,15 +81,11 @@ runs:
set -euo pipefail

ENDPOINT="http://${SPICEIO_BIND}"
PID_FILE="${{ steps.install.outputs.pid_file }}"

# Skip if spiceio is already listening on the requested address
Comment thread
lukekim marked this conversation as resolved.
# Verify it's spiceio by checking for the "spiceio" server header
if curl -sf -I "$ENDPOINT/" 2>/dev/null | grep -qi "server: spiceio"; then
echo "spiceio already running at $ENDPOINT — skipping start"
echo "endpoint=$ENDPOINT" >> "$GITHUB_OUTPUT"
echo "pid=" >> "$GITHUB_OUTPUT"
echo "skipped=true" >> "$GITHUB_OUTPUT"
exit 0
fi

Expand Down Expand Up @@ -137,10 +129,7 @@ runs:

spiceio &
PID=$!
echo "$PID" > "$PID_FILE"
echo "pid=$PID" >> "$GITHUB_OUTPUT"
echo "endpoint=$ENDPOINT" >> "$GITHUB_OUTPUT"
echo "skipped=false" >> "$GITHUB_OUTPUT"

# Wait for readiness
echo "Waiting for spiceio on ${SPICEIO_BIND}..."
Expand All @@ -158,17 +147,3 @@ runs:
echo "::error::spiceio failed to start within 30s"
exit 1

- name: Register cleanup
if: always() && steps.start.outputs.skipped != 'true'
shell: bash
run: |
PID_FILE="${{ steps.install.outputs.pid_file }}"
if [[ -f "$PID_FILE" ]]; then
PID=$(cat "$PID_FILE")
if kill -0 "$PID" 2>/dev/null; then
echo "Stopping spiceio (PID $PID)"
kill "$PID" 2>/dev/null || true
wait "$PID" 2>/dev/null || true
fi
rm -f "$PID_FILE"
fi
Loading