We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent 29f82c0 commit f3e78cfCopy full SHA for f3e78cf
1 file changed
vortex-metrics/src/lib.rs
@@ -81,11 +81,9 @@ impl VortexMetrics {
81
/// Create a new metrics registry with additional tags. Metrics created in the
82
/// child registry will be included in this registry's snapshots.
83
pub fn child_with_tags(&self, additional_tags: impl Into<DefaultTags>) -> Self {
84
- let child = Self::new_with_tags(self.inner.default_tags.merge(&additional_tags.into()));
85
// TODO: Temporarily disabled due to memory growth: children accumulate indefinitely
86
// https://github.com/vortex-data/vortex/discussions/5946
87
- // self.inner.children.write().push(child.clone());
88
- child
+ Self::new_with_tags(self.inner.default_tags.merge(&additional_tags.into()))
89
}
90
91
/// Returns the counter with the specified ID, creating a default instance if absent.
0 commit comments