Skip to content

Disable child metric registration under parent to prevent OOM #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgrebnov merged 2 commits into from
Jan 14, 2026
Merged

Disable child metric registration under parent to prevent OOM #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29f82c0
Disable child metric registration under parent to prevent OOM
sgrebnov Jan 13, 2026
e4b8cd5
Lint
sgrebnov Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vortex-metrics/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ impl VortexMetrics {
/// Create a new metrics registry with additional tags. Metrics created in the
/// child registry will be included in this registry's snapshots.
Comment thread
sgrebnov marked this conversation as resolved.
pub fn child_with_tags(&self, additional_tags: impl Into<DefaultTags>) -> Self {
let child = Self::new_with_tags(self.inner.default_tags.merge(&additional_tags.into()));
self.inner.children.write().push(child.clone());
child
// TODO: Child metric registration under parent is temporarily disabled due to memory growth - children accumulate indefinitely.
// https://github.com/vortex-data/vortex/discussions/5946
Self::new_with_tags(self.inner.default_tags.merge(&additional_tags.into()))
}

/// Returns the counter with the specified ID, creating a default instance if absent.
Expand Down
Loading