forked from vortex-data/vortex
-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade spiceai-52 to Vortex 0.68.0 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
447 commits
Select commit
Hold shift + click to select a range
002f49e
fix[vortex-array]: handle lazily sliced REE to_arrow (#7011)
asubiotto 904079c
chore: clean up #[inline] annotations (#7000)
0ax1 7cf49a1
chore[ci]: use pre-build image and strip workflow installs (#7013)
joseph-isaacs b8b056d
Variant DType (#6912)
AdamGS b387a98
skip[ci]: update miri to use runs on (#7019)
joseph-isaacs 61bc044
Add backwards compatibly handling of sum stats of extension types (#7…
AdamGS 13417e9
skip[ci]: use runs-on for generated-files job (#7021)
joseph-isaacs 4fd1814
fix[compat]: Update the action to use the correct check command (#7016)
joseph-isaacs 4b99a50
MinMax AggregateFn (#7006)
gatesn 6d6faf3
fix: compat script (#7024)
joseph-isaacs c4b9949
Fix scalar partial ordering comparison (#6999)
connortsui20 ddb3d39
Simplify returned value when chunked reader is asked to read empty ra…
robert3005 c3dc5d9
skip: clean up ci prebuild image usage (#7025)
joseph-isaacs 0c7df90
More detailed docs on `ScalarFnVTable` (#7027)
connortsui20 a98f94c
Decimal sum uses smallest physical type that supports output dtype (#…
robert3005 644fcdf
IsConstant Aggregate Function (#7028)
gatesn 5c80b40
Sum aggregate doesn't include nan values (#7009)
robert3005 3cf3a17
chore(deps): update rust crate fsst-rs to v0.5.7 (#7030)
renovate[bot] ec85ffe
IsSorted AggregateFn (#7029)
gatesn cff3e15
chore(deps): update rust crate fsst-rs to v0.5.8 (#7031)
renovate[bot] 46c81ff
chore(deps): update gradle to v9.4.0 (#7032)
renovate[bot] d169713
chore(deps): update plugin com.diffplug.spotless to v8.4.0 (#7033)
renovate[bot] 5081af4
chore(deps): update plugin com.gradleup.shadow to v9.4.0 (#7034)
renovate[bot] e57c706
chore(deps): update plugin com.vanniktech.maven.publish to v0.36.0 (#…
renovate[bot] e426310
chore(deps): update rust crate criterion to 0.8 (#7037)
renovate[bot] 58834ee
chore(deps): update rust crate noodles-bgzf to 0.46.0 (#7040)
renovate[bot] 2d37a46
chore(deps): update plugin com.palantir.consistent-versions to v3.15.…
renovate[bot] 625bbf6
chore(deps): update rust crate noodles-vcf to 0.86.0 (#7041)
renovate[bot] f97e0b3
chore(deps): update rust crate sketches-ddsketch to 0.4.0 (#7047)
renovate[bot] 1e062d0
chore(deps): update rust crate sysinfo to 0.38.0 (#7049)
renovate[bot] bfe1858
chore(deps): update rust crate strum to 0.28 (#7048)
renovate[bot] 6cf38a2
chore(deps): update rust crate test-with to 0.15 (#7050)
renovate[bot] 7df9f15
chore(deps): update actions/checkout action to v6 (#7055)
renovate[bot] 74122c2
chore(deps): update aws-actions/configure-aws-credentials action to v…
renovate[bot] b05cd6e
chore(deps): update actions/download-artifact action to v8 (#7056)
renovate[bot] 5088456
chore(deps): update ssciwr/doxygen-install action to v2 (#7060)
renovate[bot] 7cd2206
chore(deps): update rust crate zip to v8 (#7059)
renovate[bot] bf0ec1c
chore(deps): update rust crate pyo3 to 0.28.0 (#7043)
renovate[bot] 8e706cb
chore(deps): update rust crate rand_distr to 0.6 (#7046)
renovate[bot] 27c06b4
chore(deps): update rust crate termtree to v1 (#7058)
renovate[bot] 20070d2
chore(deps): update rust crate oneshot to 0.2.0 (#7042)
renovate[bot] 683ba3a
Canonical variant array (#7026)
AdamGS 8efe1dc
Vector Extension Type (#6964)
connortsui20 402d5ce
Print to stdout in `compress-bench` and `random-access-bench` (#7065)
connortsui20 d260d42
Update CLAUDE.md (#7069)
gatesn cf1c050
perf[fsst]: like pushdown using a dfa (#6935)
joseph-isaacs 9a9a3ce
chore[fuzz]: (temp) remove duplicate struct field names (#7073)
joseph-isaacs ea106e4
fix[scalar_fns]: add correct pre-condition checks for all custom push…
joseph-isaacs 43ae2dc
chore: `AggregateFnRef` [de]serialize (#7070)
blaginin 236d5cc
fix[back-compat]: use superset not subset in the check mod (#7075)
joseph-isaacs b1ab304
Show truncation indicator in array display (#7072)
dimitarvdimitrov caa2420
chore: cache cpu feat check for micro-benchmarks (#7079)
0ax1 4829e13
Fuzzer includes unstable_encodings (#7081)
robert3005 4a0ed9b
feat(cuda): add `SEQUENCE` source op to dyn dispatch (#7078)
0ax1 967dce5
Update DeltaArray to always pad values to 1024 elements and use bit t…
robert3005 124c698
fix fuzzer issue #7074 (#7077)
joseph-isaacs 7efebc4
chore[mask]: intersect_by_rank benchmarks (#7083)
joseph-isaacs 8e1fe29
skip: CI / CUDA tests (san in parallel) (#7076)
joseph-isaacs 6895aa5
chore[fuzz]: run for less time more often (#7097)
joseph-isaacs cbf85ad
chore(deps): update rust crate tar to v0.4.45 [security] (#7099)
renovate[bot] 2ec79da
bump aws-lc-rs to clear advisory (#7100)
onursatici bb45280
default mimalloc for vortex-python wheels (#7096)
onursatici 062f36c
do not validate already valid arrow varbin arrays (#7089)
onursatici e5d4315
Remove `vortex-test-e2e` (#7102)
connortsui20 39b24da
chore(deps): lock file maintenance (#7088)
renovate[bot] 0c29fc4
Function to return vtable from an array (#7085)
gatesn 18359a8
Only pass vtable once via ExtDType<V> (#7105)
gatesn f5c5e15
chore(deps): update codspeedhq/action digest to 1c8ae48 (#7116)
renovate[bot] 0aa7f7f
chore(deps): update taiki-e/cache-cargo-install-action digest to 1ce8…
renovate[bot] 1b6ed77
chore(deps): update all patch updates (#7119)
renovate[bot] 2325594
chore(deps): update datafusion monorepo to v52.4.0 (#7120)
renovate[bot] b79b7d6
chore(deps): lock file maintenance (#7121)
renovate[bot] cbc8ad1
chore[fuzz]: new unstable encodings fuzzer run (#7123)
joseph-isaacs 1c8667c
fix[delta]: compress with nulls undef values use last valid value (or…
joseph-isaacs 7f541db
feat(cuda): hybrid GPU dispatch - fuse dyn + standalone kernels (#7127)
0ax1 8fd83ab
chore[release]: add compat-gen-upload to release (#7067)
joseph-isaacs 6efc235
Testing FFI from C side (#7126)
myrrc 0b75700
feat[array]: change VTable execution to pass owned arrays (#6867)
joseph-isaacs 7b09ee5
docs: clarify GPU dispatch flow (#7132)
0ax1 539288e
Fuzzer uses same mask for expected and actual value (#7133)
robert3005 f03a0c7
Update vtables docs regarding forwarding from erased to typed (#7134)
gatesn 2a68ffa
fix: disambiguate array ops files (#7137)
0ax1 5a11eee
Revert "fix: disambiguate array ops files" (#7138)
joseph-isaacs e25e26d
Cleanup fastlanes encodings crate (#7118)
robert3005 41616b4
skip[fuzz]: remove undefined binary name (#7139)
joseph-isaacs 9f0f8ff
chore[array]: add filter bool bench (#7122)
joseph-isaacs 8f13bda
feat[array]: use transmute for up/down cast of Arc<Array> (#7140)
joseph-isaacs 04776cc
Remove BitBuffer::into_mut and require callers to handle failure to a…
robert3005 cda251b
fix fuzz_report script (#7141)
a10y 0ea8973
Part 2 of making Variant a canonical array (#7143)
AdamGS 37c01c0
fix: remove nested `block_on` call in `cuda_execute` (#7147)
0ax1 6cef60b
chore[array]: iterative execute method p1 (#6860)
joseph-isaacs c790cfb
Support reading SparseArray with non zero offset (#7150)
robert3005 f200823
fill_forward_nulls resets at 1024 chunk boundary (#7149)
robert3005 41b997d
fix(python): cap substrait below 0.85.0 (#7153)
RealXuChe ec2c602
feat[vortex-datafusion]: use PartitionedFile instead of path in creat…
asubiotto 2383946
Add web UI (#7151)
gatesn b9132aa
fix(python): cap substrait-python before 0.29.0 (#7161)
RealXuChe 6027a9c
Add storybook for component development (#7162)
gatesn 8aae4ba
Make vortex-scan just the Scan API (#7163)
gatesn b66cfcb
spark: pass format options into reader (#7160)
a10y 7852ece
fix: dyn dispatch requires same bit width types (#7164)
0ax1 37bb73d
Shade jackson in vortex-jni and vortex-spark and avoid scala version …
robert3005 97e6c45
Fix docs deploy after java changes (#7170)
robert3005 66b0f40
Expand execution docs (#7158)
AdamGS aa108c6
Fix java docs build for real (#7171)
robert3005 a773f86
fix path for javadoc CI (#7173)
a10y c256ccd
fix: support total_size=0 in byte_range_to_row_range (#7115)
aalexandrov 9b1f954
Upgrade to DataFusion 53 (#6740)
AdamGS ce9f13d
make Mimalloc opt-in for ffi (#7179)
myrrc 86c3568
Filter indices without an iterator for Bool (#7176)
AdamGS c8eae59
Add tsan for vortex-ffi, fix asan instrumentation (#7157)
myrrc 1e0e6d0
Upgrade fsst-rs to 0.5.9 (#7177)
AdamGS be4761a
feat: teach docs about object store (#7169)
danking b32c6b9
Specialize export of chunked list arrays (#7180)
AdamGS 656b3fe
Array VTables Migration (#7181)
gatesn 9855100
Array VTables Migration 1b (#7182)
gatesn 7aa556a
chore[gpu]: split plan into unmaterialized / materialized (#7175)
0ax1 8b83d7b
Array VTables Migration 2 (#7183)
gatesn fa6931a
scalar_at take execution_ctx (#7166)
a10y 66236f8
Array VTables Migration 3 (#7185)
gatesn 05e5d38
fix: vortex-cxx test race (#7189)
0ax1 48fe372
Run TPC-H SF 100 nightly on Vortex (#7184)
AdamGS 6fade3c
Unify benchmark dispatch into a workflow (#7178)
AdamGS 5369859
feat: make dispatch plan dynamically sized (#7186)
0ax1 66db19a
feat: Java Bindings for FixedSizeList (#7188)
JingsongLi b524763
Cache python class imports (#7191)
AdamGS 1f3206f
Make sure all tokio runtime propegate observability in the same way (…
AdamGS 60847b0
move BitPacked slice from kernel -> parent reduce (#7195)
a10y d0ed3fc
Python benchmarks script and re-organize dev dependencies (#7192)
AdamGS 2258dd3
New Parquet-Variant encoding (#7130)
AdamGS a545239
fix: restrict wasm-bindgen to browser wasm, fixing wasip1 builds (#7208)
0ax1 c85f7a2
feat(cuda): single-pass dispatch plan builder (#7197)
0ax1 f3a9ff5
Expose expressions for C API (#7190)
myrrc 3c5fbd3
fix[ci]: correct perms to upload back compat fixtures (#7207)
joseph-isaacs e8cd130
Vortex Explorer UI (#7165)
gatesn 65a8185
feat: Introduce writeBatchFfi in Java JNI to avoid IPC serialization …
JingsongLi e6bd36f
chore(deps): update taiki-e/cache-cargo-install-action digest to 5118…
renovate[bot] 60aba91
chore(deps): update codspeedhq/action digest to d872884 (#7202)
renovate[bot] 16f1a7f
Deploy Explorer (#7211)
gatesn fb4ac44
feat[array]: compositional array display logic (#7082)
joseph-isaacs 5ce08ed
array slots (#6870)
joseph-isaacs 9f10dfa
perf: speed up TryFrom<Scalar> for Primitive (#7223)
joseph-isaacs 10c3fc6
Assert_arrays_eq also executes the array and compares the results aga…
robert3005 5e93e8e
Move stuff around `vortex-tensor` (#7225)
connortsui20 8c48a53
Pluggable Compressor (#7018)
connortsui20 df84cee
fix[vortex-array]: fix overflow on FSL element take indices (#7214)
asubiotto c5d2745
Approximate expressions for tensor types (#7226)
connortsui20 faf98f2
PatchedArray: basics and wiring (#7002)
a10y 4e4ea56
fix[vortex-array]: update an overflow test (#7229)
asubiotto 0e352e5
Add compressor for constant nonnullable and all valid bool arrays (#7…
robert3005 3f5913f
chore: have on demand validity and patches for array remove slot extr…
joseph-isaacs b380c53
buffered strategy to not use eof for the final chunk (#7219)
onursatici 6989b98
skip[ci]: wait for sccache in actions (#7237)
joseph-isaacs db00b43
Remove deprecated compute traits (#7231)
gatesn bd9f543
Fill out a few small pieces in Variant (#7209)
AdamGS ba827a4
fix: fix typo in compressor scheme (#7241)
joseph-isaacs 3ea259e
Fix semantic conflict with array slots (#7243)
robert3005 8060ae0
Support partitionBy in VortexSparkDataSource (#7218)
robert3005 a3f290c
remove deprecated StructStrategy (#7242)
a10y a6cc251
ffi: expose array validity, allow creating primitive arrays (#7148)
myrrc 6cfb2b0
docs: add back array children docs moved from slots (#7249)
joseph-isaacs 267d6ee
Crosshairs for filemap (#7247)
gatesn e3b7310
feat: iterative execute alp/alp_rd/bitpacking (#7233)
joseph-isaacs 19403db
Update FSL take test to fail with assert_arrays_eq! without explicit …
robert3005 fcfd443
skip[ci]: remove `debug-assertions=yes` from codspeed runs (#7252)
joseph-isaacs 6fdd0b3
Silence unused warning (#7254)
connortsui20 59b0083
alp_rd: speedup (#7064)
joseph-isaacs 13937c0
make struct_fields boxed, not arc'd (#7257)
myrrc 37b7625
break: apply should use `apply(self: Arc<Self>, ...)` over `apply(&se…
joseph-isaacs 2eb4f7d
fix[ffi]: to and from ffi types should have a fully defined cast (#7261)
joseph-isaacs 0368c39
skip[ci]: use warm pool for ci (#7253)
joseph-isaacs 38ab5af
ffi: StructArray creation (#7260)
myrrc f43e12b
Array VTables (#7215)
gatesn 3ed9492
take `VortexSession` by ref (#7270)
connortsui20 f782a6e
fix comment (#7272)
a10y 886aefc
Invert the`vortex-tensor` dependency (#7271)
connortsui20 b573853
Clean up btrblocks compressor interface (#7274)
connortsui20 5d0d627
Require two humans for bot authored PRs (#7232)
gatesn d879349
Fix tensor expressions and add `InnerProduct` expression (#7277)
connortsui20 02b0949
Cleaner `WriteStrategyBuilder` interface (#7275)
connortsui20 1f6db85
chore(deps): update release-drafter/release-drafter action to v7 (#6943)
renovate[bot] 78cdcf2
Remove unused approvals workflow triggers (#7280)
gatesn 017f7a7
Fix badly formatted docs (#7281)
connortsui20 a8351a9
Correctly gate zstd (#7283)
connortsui20 bf97ba2
Array VTables Follow Up (#7276)
gatesn 16bbd12
Add comment showing change in benchmark file sizes (#7264)
a10y c1b9223
Fix Array::validity (#7285)
gatesn e3c7401
Revert "Add comment showing change in benchmark file sizes (#7264)" (…
connortsui20 b2a5a70
TurboQuant encoding for Vectors (#7269)
connortsui20 d5c21dc
Fix ALP mask patches dtype (#7293)
gatesn 2335b79
feat:`Count` aggegate (#7267)
blaginin 1fa9ebe
Fix clippy on develop (#7295)
gatesn 1c2348a
Bring back file-size comments (#7296)
a10y e415157
Change tensor utils names (#7284)
connortsui20 6eee669
Fix semantic merge confict in vortex-tensor (#7299)
connortsui20 11d607e
Hoist Slots (#7287)
gatesn cca6e9e
Fix `TurboQuant` metadata to be protobuf (#7301)
connortsui20 de4eb39
ArrayPlugin (#7302)
gatesn 0170156
Tensor Matchers (#7300)
connortsui20 c1f764b
chore(deps): update actions/github-script digest to 450193c (#7290)
renovate[bot] 2e4b405
chore(deps): update taiki-e/cache-cargo-install-action digest to 66c9…
renovate[bot] 4b3d712
drop unused code (#7304)
a10y bf95b6f
Fix StructArray / StructData after migration (#7305)
gatesn 8584d27
benchmarks website dark mode (#6886)
myrrc 613638a
chore(deps): update dependency vite to v6.4.2 [security] (#7303)
renovate[bot] b0cf87b
Do we need to explicitly install ninja? (#7310)
robert3005 951bdf9
fix: array correctly update their validity (#7307)
joseph-isaacs 6c7eb33
fix[vortex-array]: fix offset_within_chunk underflow on patches array…
asubiotto 7a144d3
feat: `First` `Last` (#7313)
blaginin 6f291c7
break[array]: remove old `vtable!` macro (#7317)
joseph-isaacs ba920ab
Allow inserting non-Default values to VortexSession (#7321)
gatesn 006ed43
TurboQuant Cleanup part 1 (#7320)
connortsui20 29a5f43
RLE handles decompression of indices where invalid positions are clob…
robert3005 b8f8bd5
fix[encodings]: take in progress buffer into account on fsst builder …
asubiotto 9dcb75e
block serialization for the existing aggregations (#7322)
blaginin 06065ff
Normalize Execution (#7278)
gatesn be65147
Rework `Scheme` estimation in compressor (#7230)
connortsui20 8d55015
TurboQuant cleanup part 2 (#7326)
connortsui20 0b52e48
more improvements to file sizes comments (#7319)
a10y b9c47cf
L2 Denorm expression (#7329)
connortsui20 95befa7
feat: fsst inline varbin child (#7316)
joseph-isaacs 001f44b
Don't re-run benchmarks nightly (#7338)
AdamGS bbb371c
Symlink CLAUDE.md to AGENTS.md to support other coding agents (#7333)
AdamGS f87eefa
feat[gpu]: support mixed-width types in dynamic dispatch (#7331)
0ax1 2e00050
Dynamic WHT rounds in TurboQuant (#7330)
connortsui20 5adc437
Unify id creation for ScalarFns and rename is_null to vortex.is_null …
robert3005 51d34d1
move scheme files around (#7342)
connortsui20 d72bf9b
Enable clippy::clone_on_ref_ptr lint and fix all violations (#7262)
joseph-isaacs cdebcdc
feat: iterative execution (#7335)
joseph-isaacs ff21366
fix lint on develop (#7346)
a10y 0e9c0c5
Buffer Allocator Abstraction (#7337)
gatesn eacb959
Pull out `L2Denorm` from TurboQuant (#7349)
connortsui20 1748d17
Remove generic rle (#7350)
connortsui20 24736e1
Move Array::serialize -> ArrayPlugin::Serialize (#7348)
gatesn bab7798
Fix TSan data race with FFI tests (#7244)
myrrc a30de02
Add a dedicated CI build profile (#7357)
AdamGS 1d8f307
Allow loading "foreign" plugins for UI/TUI/Serde (#7347)
gatesn 84e4dc0
AVX2 take handles indices that are equal to the index type max value …
robert3005 957eb3a
Fix semantic merge conflict between session serde and foreign encodin…
robert3005 72d39fb
Fix patch_chunk index OOB when slicing ALP arrays mid-chunk (#7354)
abnobdoss 77c8e95
feat: iterative execution patched array (#7345)
joseph-isaacs c660607
add env flag for Patched array (#7314)
a10y 8974afe
feat: add an arrays slots macro (#7360)
joseph-isaacs 0b2a35e
Add IsNull expression to vortex-jni (#7358)
robert3005 ccc6590
fix: maturin never logs (#7367)
danking 47f97f4
Add inner product and cosine similarity optimizations (#7364)
connortsui20 ae906c7
Clean up `AGENTS.md` (#7366)
connortsui20 9c934a6
feat: upgrade spiceai-52 to Vortex 0.68.0
lukekim bb80c53
fix: restore lint checks on forks
lukekim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [[profile.default.overrides]] | ||
| filter = 'test(compress_large_int)' | ||
| priority = 100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: "Build and verify rebuild is a no-op" | ||
| description: "Run a cargo command, then re-run it to verify all artifacts are cached" | ||
| inputs: | ||
| command: | ||
| description: "The cargo build command to run and verify (--message-format json is appended on the verification run)" | ||
| required: true | ||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: "Build" | ||
| shell: bash | ||
| run: ${{ inputs.command }} | ||
| - name: "Verify rebuild is a no-op" | ||
| shell: bash | ||
| run: | | ||
| stale=$(${{ inputs.command }} \ | ||
| --message-format json 2>/dev/null \ | ||
| | jq -r 'select(.reason == "compiler-artifact" and .fresh == false) | .target.name') | ||
| if [ -n "$stale" ]; then | ||
| echo "ERROR: Rebuild recompiled crates that should have been cached:" | ||
| echo "$stale" | ||
| exit 1 | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| name: "Setup Prebuild" | ||
| description: "Prebuild AMIs — uses pre-installed tools, falls back to full setup-rust for forks" | ||
|
|
||
| inputs: | ||
| repo-token: | ||
| description: "GitHub token for accessing the repository (typically secrets.GITHUB_TOKEN)" | ||
| required: false | ||
| default: "${{ github.token }}" | ||
| toolchain: | ||
| description: "optional override for the toolchain version (e.g. nightly)" | ||
| required: false | ||
| components: | ||
| description: "optional override for the components to install for the step (e.g. clippy, rustfmt, miri)" | ||
| default: "clippy, rustfmt" | ||
| required: false | ||
| targets: | ||
| description: "optional targets override (e.g. wasm32-unknown-unknown)" | ||
| required: false | ||
| enable-sccache: | ||
| description: "Should sccache be enabled, true by default." | ||
| required: false | ||
| default: "true" | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| # Prebuild path: tools already installed, just configure sccache | ||
| - name: Configure sccache timeout | ||
| if: github.repository == 'vortex-data/vortex' && inputs.enable-sccache == 'true' | ||
| shell: bash | ||
| run: | | ||
| mkdir -p ~/.config/sccache | ||
| echo 'server_startup_timeout_ms = 60000' > ~/.config/sccache/config | ||
|
|
||
| - name: Pre-start sccache server | ||
| if: github.repository == 'vortex-data/vortex' && inputs.enable-sccache == 'true' | ||
| shell: bash | ||
| run: sccache --start-server | ||
|
|
||
| # Fallback path: full setup for forks | ||
| - name: Full Rust setup | ||
| if: github.repository != 'vortex-data/vortex' | ||
| uses: ./.github/actions/setup-rust | ||
| with: | ||
| repo-token: ${{ inputs.repo-token }} | ||
| toolchain: ${{ inputs.toolchain }} | ||
| components: ${{ inputs.components }} | ||
| targets: ${{ inputs.targets }} | ||
| enable-sccache: ${{ inputs.enable-sccache }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1 @@ | ||
| images: | ||
| vortex-ci-amd64: | ||
| platform: "linux" | ||
| arch: "x64" | ||
| name: "vortex-ci-*" | ||
| owner: "375504701696" | ||
| vortex-ci-arm64: | ||
| platform: "linux" | ||
| arch: "arm64" | ||
| name: "vortex-ci-*" | ||
| owner: "375504701696" | ||
| _extends: .github-private |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| name: PR Approval Check | ||
|
|
||
| on: | ||
| pull_request_review: | ||
| types: [submitted, dismissed] | ||
|
|
||
| jobs: | ||
| check-approvals: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check required approvals | ||
| uses: actions/github-script@450193c5abd4cdb17ba9f3ffcfe8f635c4bb6c2a | ||
| with: | ||
| script: | | ||
| const pr = context.payload.pull_request; | ||
| const reviews = await github.rest.pulls.listReviews({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| pull_number: pr.number, | ||
| }); | ||
|
|
||
| // Count unique human approvals (latest review per user) | ||
| const latestByUser = {}; | ||
| for (const review of reviews.data) { | ||
| if (review.user.type === 'Bot') continue; | ||
| latestByUser[review.user.login] = review.state; | ||
| } | ||
| const approvalCount = Object.values(latestByUser) | ||
| .filter(state => state === 'APPROVED').length; | ||
|
|
||
| // Determine if PR author is a bot/GitHub Actions | ||
| const authorType = pr.user.type; // 'Bot' vs 'User' | ||
| const authorLogin = pr.user.login; // e.g. 'github-actions[bot]' | ||
| const isBot = authorType === 'Bot' || authorLogin.endsWith('[bot]'); | ||
|
|
||
| const required = isBot ? 2 : 1; | ||
|
|
||
| console.log(`PR author: ${authorLogin} (${authorType}), isBot: ${isBot}`); | ||
| console.log(`Approvals: ${approvalCount} / ${required} required`); | ||
|
|
||
| if (approvalCount < required) { | ||
| core.setFailed( | ||
| `This PR needs ${required} human approval(s) but has ${approvalCount}. ` + | ||
| `(Author is ${isBot ? 'a bot' : 'human'})` | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.