fix(lyrics-plus): properly set height on main view #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lseoksee
changed the title
1.2.57+ Lyrics plus page Issue1.2.57+ lyrics plus page Issue
Lseoksee
changed the title
1.2.57+ lyrics plus page Issue
|
That’s hacky. These elements should be mapped first then we can “modify” them |
Should I update |
yes. check first if it was mapped in earlier versions, so you can use the same name for them, but if not, you would need to come up with some name for those |
|
@rxri |
rxri
changed the title
rxri
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3320