Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lyrics-plus): properly set height on main view #3322

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

Lseoksee
Copy link
Contributor

fix #3320

@Lseoksee Lseoksee changed the title fix(lyrics-plus): 1.2.57+ Lyrics plus page Issue fix(lyrics-plus): 1.2.57+ lyrics plus page Issue Feb 20, 2025
@Lseoksee Lseoksee changed the title fix(lyrics-plus): 1.2.57+ lyrics plus page Issue fix(lyrics-plus): lyrics plus page Issue Feb 20, 2025
@Lseoksee Lseoksee mentioned this pull request Feb 20, 2025
2 tasks
@rxri
Copy link
Member

rxri commented Feb 20, 2025

That’s hacky. These elements should be mapped first then we can “modify” them

@Lseoksee
Copy link
Contributor Author

That’s hacky. These elements should be mapped first then we can “modify” them

Should I update css-map.json?

@rxri
Copy link
Member

rxri commented Feb 20, 2025

That’s hacky. These elements should be mapped first then we can “modify” them

Should I update css-map.json?

yes. check first if it was mapped in earlier versions, so you can use the same name for them, but if not, you would need to come up with some name for those

@Lseoksee
Copy link
Contributor Author

Lseoksee commented Feb 21, 2025

@rxri
There were no identical elements from the previous version, so I updated css-map.json with appropriate key values.

@rxri rxri changed the title fix(lyrics-plus): lyrics plus page Issue fix(lyrics-plus): properly set height on main view Feb 21, 2025
@rxri rxri merged commit 37fa210 into spicetify:main Feb 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lyrics plus appearing halved
2 participants