Skip to content

feat: switch to biome to ensure consistency & apply various fixes #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2024

Conversation

afonsojramos
Copy link
Member

This repo contains multiple files with different types of spacing, formatting done via eslint, which is not recommended by the team itself, so this pr introduces biome, which has already been implemented in spicetify/cli.

@afonsojramos afonsojramos requested a review from a team as a code owner May 20, 2024 23:02
@afonsojramos afonsojramos requested review from Delusoire and removed request for a team May 20, 2024 23:02
@afonsojramos afonsojramos changed the title feat: switch to biome to ensure consistency feat: switch to biome to ensure consistency & apply various fixes May 21, 2024
@rxri rxri merged commit 15900b9 into main May 21, 2024
6 checks passed
@rxri rxri deleted the feat/biome branch May 21, 2024 18:07
@theRealPadster
Copy link
Member

Why are we using no trailing commas? Should be "always" for more readable diffs.

@rxri
Copy link
Member

rxri commented May 24, 2024

Why are we using no trailing commas? Should be "always" for more readable diffs.

Should be "es5". Didn't notice it. Not really much of the deal because the marketplace code is going to be replaced soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants