Skip to content

Conversation

@ssatwik975
Copy link
Contributor

Closes #880. Fixed resize handle positions upon switching sidebar positions. Drag to resize works in reverse / pre-switching context.

@ssatwik975 ssatwik975 requested a review from a team as a code owner January 20, 2025 23:21
@ssatwik975 ssatwik975 requested review from rxri and removed request for a team January 20, 2025 23:21
Copy link
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint code & commit only your changes, don't reformat the entire file

@kyrie25 kyrie25 changed the title fix: fixes resize handle positions upon switching sidebar positions fix(snippet/switch-sidebars): reposition resize handle Jan 21, 2025
@kyrie25 kyrie25 merged commit fce70c6 into spicetify:main Jan 21, 2025
6 checks passed
@ssatwik975
Copy link
Contributor Author

Thank you :D

@bum8hj
Copy link

bum8hj commented Jan 21, 2025

Thanks for the effort. However, it's not fully behaving as it should (although better).
Here's a video:

spicetify.mp4

@ssatwik975
Copy link
Contributor Author

ssatwik975 commented Jan 22, 2025

Yeah the dragging behaviour is still the same i.e. reversed or pre-switching context. You can drag them off the edge of the application window. Afaik there isn't really a way to alter that via snippets. Regardless, I really like this snippet and use it a lot so I hope someone can improve on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch Sidebars snippet does not switch the resize behavior

3 participants