fix(website): crawl_raw uses raw sitemap chain on chrome builds#393
Merged
Conversation
crawl_raw runs the main crawl over plain HTTP via crawl_concurrent_raw, but then calls sitemap_crawl_chain for the sitemap pass. On a chrome-enabled build that chain resolves to sitemap_crawl_chrome, so an HTTP-only crawl unexpectedly launches a browser (this also affects the CLI's --http flag). Add sitemap_crawl_chain_raw and call it from crawl_raw so the sitemap pass stays on the HTTP path in every build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously spider would use chrome when running
crawl_rawfor sitemap crawling. This PR makes it use thesitemap_crawl_rawforcrawl_rawlike it would without thechromefeature enabled.Co-Authored by Claude Opus 4.8
Checklist
cargo testpasses (seems to be some preexisting failures)cargo fmtapplied