feat: add on_link_blocked_callback for robots.txt blocked URLs#394
Merged
Conversation
Add an OnLinkBlockedCallback that fires when a link is denied by robots.txt rules, allowing consumers to observe and log blocked URLs without extra polling.
zanmato
force-pushed
the
feat/robots-blocked-callback
branch
from
15ef5f1 to
1dea006
Compare
Restore the original short-circuit in is_allowed_default: is_allowed_robots is only evaluated when whitelist/blacklist do not already block, instead of the eager `let blocked_robots = !self.is_allowed_robots(...)` that ran the robots check on every link. The on_link_blocked_callback now fires only when robots.txt is the actual block reason (not when whitelist/blacklist blocks), via a clean else-if branch. Robots condition semantics unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using spider for SEO-crawling, and need to know which URLs are blocked by robots.txt.
What does this PR do?
Add an OnLinkBlockedCallback that fires when a link is denied by robots.txt rules, allowing consumers to observe and log blocked URLs without extra polling.
Co-Authored by Claude Opus 4.7
Checklist
cargo testpassescargo fmtapplied