Skip to content

Conversation

@cyclinder
Copy link
Collaborator

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #

Special notes for your reviewer:

@cyclinder cyclinder added the release/feature-new release note for new feature label Feb 28, 2025
@cyclinder cyclinder force-pushed the dra/v1beta1 branch 4 times, most recently from 0ddd782 to e1b8583 Compare March 20, 2025 03:49
@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 94 lines in your changes missing coverage. Please review.

Project coverage is 74.27%. Comparing base (f45bdac) to head (4516eaa).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
pkg/podmanager/utils.go 0.00% 77 Missing ⚠️
pkg/podmanager/pod_webhook.go 0.00% 12 Missing ⚠️
pkg/utils/utils.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4695      +/-   ##
==========================================
- Coverage   75.27%   74.27%   -1.00%     
==========================================
  Files          56       56              
  Lines        6770     6861      +91     
==========================================
  Hits         5096     5096              
- Misses       1461     1552      +91     
  Partials      213      213              
Flag Coverage Δ
unittests 74.27% <0.00%> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/utils/utils.go 65.76% <0.00%> (-3.11%) ⬇️
pkg/podmanager/pod_webhook.go 0.00% <0.00%> (ø)
pkg/podmanager/utils.go 30.97% <0.00%> (-21.32%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cyclinder cyclinder force-pushed the dra/v1beta1 branch 4 times, most recently from 0c95492 to 5e72b02 Compare March 25, 2025 10:47
mountPath: /var/run/netns
mountPropagation: Bidirectional
{{- end }}
{{- if .Values.spiderpoolAgent.dra.enabled }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个建议不要做这个判断,而是默认就是要加载,因为 开关由 configmap 中决定,否则功能的 使能 就不是简单 设置 configmap,而是要 helm upgrade 。那么 configmap 中的 开关作用 就不大了

这里 理想的是 应该是要 通过 helm 检测 k8s ablitiy dra ,来决定是否加载

@cyclinder cyclinder changed the title DRA: support staticNis for multi-network DRA: support staticNis and dynamicNics Mar 27, 2025
@cyclinder cyclinder force-pushed the dra/v1beta1 branch 9 times, most recently from 4378480 to 4516eaa Compare May 12, 2025 10:18
@cyclinder cyclinder force-pushed the dra/v1beta1 branch 6 times, most recently from 5a79125 to 65fdabf Compare May 21, 2025 13:06
@github-actions github-actions bot removed the pr/stale This pull is inactive label Nov 4, 2025
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
@cyclinder cyclinder changed the title DRA: support staticNis and dynamicNics Add DRA Networking support Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/feature-new release note for new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants