Fix X509SVID hint deduplication to apply only to non-empty hints #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only non-empty X509SVID hints participate in deduplication, in accordance with the SPIFFE Workload API specification. SVIDs without a hint are no longer incorrectly filtered out. Signed-off-by: Max Lambrecht <[email protected]>
rturner3
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align X509SVID hint handling with the SPIFFE Workload API specification by deduplicating only non-empty hint values. Empty (unset) hints are no longer treated as duplicates, ensuring all valid SVIDs are preserved while still selecting the first occurrence when duplicate non-empty hints are present.
Fixes #364