Skip to content

skip ejcba non x86; pipe through IGNORE_SUITES #6020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikebrow
Copy link
Contributor

@mikebrow mikebrow commented Apr 18, 2025

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included? manual make integration runs output below..
  • Documentation updated?

Affected functionality
adds support for running local make integration tests on non-x86 arch development platforms.. e.g. linux/arm64

  1. pipe's the IGNORE_SUITES env through to the integration test script
  2. add the ejbca suit to the ignore list in the case of non-x86 arch, as ejbca is not currently supported https://hub.docker.com/r/keyfactor/ejbca-ce/tags

fixes #6019

before (on linux/arm64)

make integration
....
error: Internal error occurred: unable to upgrade connection: container not found ("ejbca")
Failed to execute the EJBCA init script
namespace "ejbca" deleted
[2025-04-18T18:37:49Z] step 01-setup-ejbca failed
[2025-04-18T18:37:49Z] executing teardown...
error: error from server (NotFound): namespaces "spire" not found in namespace "spire"
Deleting cluster "ejbca-test" ...
Deleted nodes: ["ejbca-test-control-plane"]
[2025-04-18T18:37:50Z] "upstream-authority-ejbca" test suite failed.
STATUS=0
[2025-04-18T18:37:50Z] The following tests failed: upstream-authority-ejbca
make: *** [Makefile:320: integration] Error 1

after

test suite succeeded.

Example:

root@ubuntuvm:/home/mike/go/src/github.com/spiffe/spire# uname -m
aarch64
root@ubuntuvm:/home/mike/go/src/github.com/spiffe/spire# uname -s
Linux

root@ubuntuvm:/home/mike/go/src/github.com/spiffe/spire# IGNORE_SUITES='suites/upstream-authority-vault' SUITES='suites/upstream-authority-ejbca suites/upstream-authority-vault' make integration
Testing suites/upstream-authority-ejbca suites/upstream-authority-vault
[2025-04-19T04:11:13Z] Ignoring suites/upstream-authority-ejbca suite...
[2025-04-19T04:11:13Z] Ignoring suites/upstream-authority-vault suite...

@mikebrow mikebrow force-pushed the makefile-update-for-non-x86-arch branch from 4d68ff3 to 270d322 Compare April 19, 2025 04:09
@faisal-memon
Copy link
Contributor

Thanks @mikebrow LGTM.

@amartinezfayo amartinezfayo self-assigned this Apr 22, 2025
@amartinezfayo
Copy link
Member

Thank you @mikebrow for this contribution.
I tested the upstream-authority-ejbca test suite in a mac with arm64 architecture and the test succeeded, which suggests me that there may be something else going on here. Could you provide more details on the environment where you executed the test?

In any case, I don't think that we should disable the test suite as a fix. SPIRE publishes arm64 artifacts in every release as a supported platform, so if there is a problem with the test suite, we should fix the test to be executed properly in arm64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements suggested for developer local make integration testing
3 participants