adding unit test variations for sigstore #6023
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebrow
requested review from
evan2645,
amartinezfayo,
sorindumitru,
MarcosDY and
rturner3
as code owners
mikebrow
force-pushed
the
sigstore-unit-test-additions
branch
2 times, most recently
from
75410be to
3ac6d99
Compare
|
finished adding unit buckets for this .go for now hit my 90% target :-) |
Signed-off-by: Mike Brown <[email protected]>
mikebrow
force-pushed
the
sigstore-unit-test-additions
branch
from
3ac6d99 to
435eb4b
Compare
|
bumped commit header to re-run tests looks like possible 404 flake (unrelated to this PR) in the httpchallenge bucket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve unit coverage for sigstore
Pull Request check list
Affected functionality
added unit test coverage for internal processRegistryCredentials() ignore invalid credential options (nil, and no user/password)
https://github.com/spiffe/spire/blob/main/pkg/agent/common/sigstore/sigstore.go#L401-L424
and setting default public rekor URL
(https://github.com/spiffe/spire/blob/main/pkg/agent/common/sigstore/sigstore.go#L94-L96)
and various checks against failures to extract details from signatures
from
ok github.com/spiffe/spire/pkg/agent/common/sigstore 0.019s coverage: 85.4% of statements
to
ok github.com/spiffe/spire/pkg/agent/common/sigstore 0.013s coverage: 91.0% of statements