Fix for TestTLSConfig/success_watching_cert_file_changes flaky test
#6513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustín Martínez Fayó <[email protected]>
amartinezfayo
requested review from
MarcosDY,
evan2645,
rturner3 and
sorindumitru
as code owners
sorindumitru
approved these changes
Dec 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
TestTLSConfig/success_watching_cert_file_changesflaky test where the test would occasionally fail with "Condition never satisfied" errors when checking for certificate updates.The test had a race condition where it would advance the mock clock and immediately check for certificate updates, but the watcher goroutine's ticker might not have been fully initialized yet. This caused intermittent failures when the test ran before the ticker was ready.
Added
clk.WaitForTicker()synchronization after starting the file watcher goroutine. This ensures the ticker is fully initialized before any test cases execute, eliminating the race condition.