Skip to content

Fix some MySQL URL issues, update documentation #3186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soininen merged 3 commits into from
Oct 8, 2025
Merged

Fix some MySQL URL issues, update documentation #3186

soininen merged 3 commits into from
Oct 8, 2025

Conversation

@soininen
Copy link
Contributor

@soininen soininen commented Oct 8, 2025 •
edited
Loading

  • Fix SQLAlchemy URL stringification
  • Update Data Connection docs

Re #3178

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

@soininen
Remove logger_interface, it is now in spine_engine
ec91cc1 
KernelEditorBase is now its own logger.

Re #3178
@soininen
Update documentation
fd89eb2 
Data Connection now supports directory references
and the references can be modified.

Re #3178
@soininen
Fix SQLAlchemy URL -> string conversions
0253088 
Using str() to convert SQLAlchemy URL to string hides passwords
which is undesirable when we want to use the entire URL. This fixes
some use cases that were missing in PR #3182
@soininen soininen force-pushed the toolbox_3178_directory_resource branch from 438d171 to 0253088 Compare October 8, 2025 13:37
@codecov
Copy link

codecov bot commented Oct 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 37.03704% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.97%. Comparing base (8655f91) to head (0253088).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
spinetoolbox/widgets/kernel_editor.py 31.91% 32 Missing ⚠️
spinetoolbox/spine_db_manager.py 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3186      +/-   ##
==========================================
+ Coverage   68.95%   68.97%   +0.01%     
==========================================
  Files         199      198       -1     
  Lines       38301    38287      -14     
  Branches     4583     4584       +1     
==========================================
- Hits        26411    26407       -4     
+ Misses      10574    10564      -10     
  Partials     1316     1316

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soininen soininen merged commit a81d97e into master Oct 8, 2025
21 of 36 checks passed
@soininen soininen deleted the toolbox_3178_directory_resource branch October 8, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@soininen