Skip to content

Conversation

@soininen
Copy link
Contributor

@soininen soininen commented Oct 10, 2025

This fixes a bug in directory size aggregator where directory sizes larger than a 32bit int could not be displayed.

Fixes #3188

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.96%. Comparing base (a81d97e) to head (1d189ae).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
spinetoolbox/widgets/project_settings_dialog.py 50.00% 2 Missing ⚠️
spinetoolbox/widgets/settings_widget.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3190      +/-   ##
==========================================
- Coverage   68.97%   68.96%   -0.01%     
==========================================
  Files         198      198              
  Lines       38287    38291       +4     
  Branches     4584     4586       +2     
==========================================
  Hits        26407    26407              
- Misses      10564    10568       +4     
  Partials     1316     1316              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soininen soininen merged commit 4e21418 into master Oct 10, 2025
18 of 19 checks passed
@soininen soininen deleted the 3188_fix_dir_size_calculator branch October 10, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calculation of large work directory size does not work

2 participants