Restrict Julia < 1.12; do not restrict SpineOpt updates #3193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpineOpt is incompatible with Julia >= 1.12
It was not possible to update SpineOpt even when an update was available if SpineOpt satisfied REQUIRED_SPINE_OPT_VERSION. This didn't really make sense: it should always be possible to update SpineOpt if a more recent version is available. If the SpineOpt Install/Update Wizard now detects that SpineOpt is installed, it offers to update it. After attempted update, it compares the versions of SpineOpt before and after the attempt notifying user on the last page whether update was successful or no update was available. It doesn't seem to be easy to find out if an update is available using Pkg in Julia, so it is better to just offer the option to update.
Looks like it doesn't come with our other dependencies anymore.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3193 +/- ##
==========================================
+ Coverage 68.83% 68.86% +0.02%
==========================================
Files 198 198
Lines 38302 38324 +22
Branches 4586 4592 +6
==========================================
+ Hits 26367 26392 +25
+ Misses 10628 10625 -3
Partials 1307 1307 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No associate issue
Checklist before merging