Fix Traceback from filtered compound model #3198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all single model's rows are always shown in compound model. This is especially true when the single models are filtered by e.g entity class or alternative selections. Still, we relied on this assumption when resolving changed rows for emitting dataChanged resulting in Tracebacks and non-updated visuals.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3198 +/- ##
=======================================
Coverage 68.82% 68.82%
=======================================
Files 198 198
Lines 38326 38336 +10
Branches 4592 4595 +3
=======================================
+ Hits 26376 26386 +10
Misses 10642 10642
Partials 1308 1308 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Tracebacks from Database editor when entities and/or alternatives were selected for editing and user updated a row in one of the stacked tables.
The Traceback itself was pretty harmless and just prevented the emission of
dataChangedwhich sometimes left old values in the UI.No associated issue.
Checklist before merging