Fix Toolbox with PySide6 6.10 #3201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method is not implemented in the QIconEngine superclass (the C++ equivalent is pure virtual) so we must have it implemented in the classes that are actually used by QIcons even though the implementation did nothing. Re #3200
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3201 +/- ##
==========================================
- Coverage 68.82% 68.82% -0.01%
==========================================
Files 198 198
Lines 38336 38340 +4
Branches 4595 4595
==========================================
+ Hits 26386 26388 +2
- Misses 10642 10644 +2
Partials 1308 1308 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the crashes caused by PySide6 6.10.
Fixes #3200
Checklist before merging